chore: replace pkg_url with https://pkg.postguard.eu/#178
Merged
Conversation
Replace the production PKG URL https://postguard-main.cs.ru.nl/pkg with https://pkg.postguard.eu/ in conf/config.toml and the commented example in conf/config.dev.toml. Since the new URL carries a trailing slash, harden the startup parameter fetch in rocket() to trim a trailing slash before appending /v2/sign/parameters (mirroring the existing trim in PkgClient::validate_api_key), avoiding a // in the request path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rubenhensen
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the production PKG URL
https://postguard-main.cs.ru.nl/pkgwithhttps://pkg.postguard.eu/, as requested in #177.conf/config.toml— activepkg_urlupdated (also dropped a stray trailing space on the line).conf/config.dev.toml— the commented-out examplepkg_urlupdated. The active dev value (http://postguard-pkg:8087) is left unchanged.Trailing-slash hardening
The requested URL ends in a trailing slash (
…postguard.eu/).PkgClient::validate_api_keyalready trims a trailing slash before building its request path, but the startup parameters fetch inrocket()did not — so a trailing slash would have producedhttps://pkg.postguard.eu//v2/sign/parameters. I added the sametrim_end_matches('/')there so the new value is safe regardless of whether the slash is present.Testing
cargo fmt --all -- --check✅cargo clippy --all-targets -- -D warnings✅cargo test --all-targets✅ (125 passing)Requested by @rubenhensen in #177.