Use `Process.RunAndCaptureText` in src/tests child-process helpers by AaronRobinsonMSFT · Pull Request #129779 · dotnet/runtime

AaronRobinsonMSFT · 2026-06-23T23:09:09Z

Adopts the new .NET 11 Process.RunAndCaptureText API across src/tests C# tests/helpers that followed the "launch a child process, wait for exit, read exit code + full stdout/stderr" pattern (no stdin, no live process control).

Converted:

Loader/PlatformNativeR2R/PlatformNativeR2R.cs
nativeaot/AggregateExecutableLibrary/ValidatorExe/ValidatorExe.cs
GC/Stress/Framework/RFLogging.cs (WriteToReport)
baseservices/exceptions/unhandled/unhandledTester.cs
baseservices/exceptions/stackoverflow/stackoverflowtester.cs
Loader/binding/tracing/BinderTracingTest.cs
profiler/common/ProfilerTestRunner.cs
nativeaot/SmokeTests/DwarfDump/Program.cs
tracing/userevents/common/UserEventsRequirements.cs
GC/Stress/Framework/ReliabilityFramework.cs (AddFailure)
GC/LargeMemory/memcheck.cs (RunCommand)
Common/CoreCLRTestLibrary/CoreclrTestWrapperLib.cs (pgrep + wmic)
Common/XUnitLogChecker/XUnitLogChecker.cs (RunProcess)

Call sites that write to stdin, coordinate with a live process (PID/signals/EventPipe), or rely on sudo/root process-tree kills were intentionally left unchanged.

Note

This PR description was generated with the assistance of GitHub Copilot.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…eText Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…aptureText Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dotnet-policy-service · 2026-06-23T23:11:33Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR refactors multiple src/tests helpers and test utilities to use System.Diagnostics.Process.RunAndCaptureText / ProcessTextOutput for the common “run child process, capture full stdout/stderr, check exit code” pattern.

Changes:

Replaces ad-hoc Process.Start + async stream reads / event handlers with Process.RunAndCaptureText(...) across several test areas.
Updates call sites to consume ProcessTextOutput.StandardOutput / .StandardError and result.ExitStatus.ExitCode (and timeout cancellation where applicable).
Simplifies a few helpers by removing manual WaitForExit / ReadToEndAsync patterns.

Show a summary per file

File	Description
src/tests/tracing/userevents/common/UserEventsRequirements.cs	Switches tracefs/user_events/ldd checks to `RunAndCaptureText` and prints captured output lines.
src/tests/profiler/common/ProfilerTestRunner.cs	Refactors profilee execution to `RunAndCaptureText` and verifies captured stdout via `TextReader`.
src/tests/nativeaot/SmokeTests/DwarfDump/Program.cs	Uses `RunAndCaptureText` for the `llvm-dwarfdump --verify` invocation and parses captured output.
src/tests/nativeaot/AggregateExecutableLibrary/ValidatorExe/ValidatorExe.cs	Simplifies ValidatorExe process execution using captured stdout/stderr and exit code.
src/tests/Loader/PlatformNativeR2R/PlatformNativeR2R.cs	Uses captured stdout/stderr for R2RDump execution and failure reporting.
src/tests/Loader/binding/tracing/BinderTracingTest.cs	Runs subprocess via `RunAndCaptureText` and writes captured stdout/stderr to the console.
src/tests/GC/Stress/Framework/RFLogging.cs	Updates status-reporting script invocation to `RunAndCaptureText`.
src/tests/GC/Stress/Framework/ReliabilityFramework.cs	Updates harness status reporting invocation to `RunAndCaptureText`.
src/tests/GC/LargeMemory/memcheck.cs	Uses `RunAndCaptureText` for a simple command execution helper.
src/tests/Common/XUnitLogChecker/XUnitLogChecker.cs	Replaces manual timeout/kill/read logic with `RunAndCaptureText(..., timeout)` and checks `ExitStatus.Canceled`.
src/tests/Common/CoreCLRTestLibrary/CoreclrTestWrapperLib.cs	Uses `RunAndCaptureText` for `pgrep` and `wmic` helpers, capturing output text directly.
src/tests/baseservices/exceptions/unhandled/unhandledTester.cs	Refactors subprocess execution to `RunAndCaptureText` and parses captured stderr lines.
src/tests/baseservices/exceptions/stackoverflow/stackoverflowtester.cs	Refactors subprocess execution to `RunAndCaptureText` and parses captured stderr lines.

Copilot's findings

Files reviewed: 13/13 changed files
Comments generated: 6

Process.RunAndCaptureText throws InvalidOperationException unless both RedirectStandardOutput and RedirectStandardError are set. Several converted call sites only redirected one stream. Also fix RFLogging status message to include the failing exit code via a {0} placeholder. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AaronRobinsonMSFT · 2026-06-24T02:25:46Z

/azp list

azure-pipelines · 2026-06-24T02:25:53Z

CI/CD Pipelines for this repository: runtime-coreclr outerloop runtime-coreclr jitstress runtime-coreclr jitstressregs runtime-coreclr jitstress2-jitstressregs runtime-coreclr gcstress0x3-gcstress0xc runtime-coreclr gcstress-extra runtime-coreclr r2r-extra runtime-coreclr jitstress-isas-x86 runtime-coreclr jitstress-isas-arm runtime-coreclr jitstressregs-x86 runtime-coreclr libraries-jitstressregs runtime-coreclr libraries-jitstress2-jitstressregs runtime-coreclr r2r runtime-coreclr runincontext runtime-coreclr crossgen2 runtime-libraries-coreclr outerloop runtime-libraries-coreclr outerloop-windows runtime-libraries-coreclr outerloop-linux runtime-libraries-coreclr outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-dev-innerloop runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly runtime-coreclr crossgen2-composite runtime-jit-experimental runtime-coreclr libraries-jitstress dotnet-linker-tests runtime-coreclr ilasm runtime-coreclr crossgen2-composite gcstress runtime-coreclr pgo runtime-coreclr libraries-pgo Antigen runtime-community Fuzzlyn runtime-coreclr superpmi-replay runtime-wasm runtime-coreclr superpmi-diffs runtime-coreclr superpmi-asmdiffs-checked-release runtime-extra-platforms jit-cfg runtime-wasm-perf runtime-llvm runtime-coreclr jitstress-random runtime-coreclr libraries-jitstress-random runtime-wasm-non-libtests runtime-android runtime-androidemulator runtime-ioslike runtime-ioslikesimulator runtime-linuxbionic runtime-maccatalyst runtime-coreclr pgostress runtime-coreclr jitstress-isas-avx512 runtime-libraries-mono outerloop runtime-sanitized runtime-wasm-dbgtests runtime-wasm-optional runtime-nativeaot-outerloop runtime-coreclr superpmi-collect-test runtime-diagnostics runtime-interpreter runtime-report-green runtime-coreclr hardware-intrinsics runtime-libraries-interpreter runtime-libraries stress-http-pr runtime-libraries stress-ssl-pr hardware-intrinsics-arm64

AaronRobinsonMSFT · 2026-06-24T02:26:50Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-06-24T02:27:07Z

Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik

@AaronRobinsonMSFT big thanks for dogfooding the new APIs! I've left some comments, PTAL

adamsitnik · 2026-06-24T09:20:07Z

            bool endOfStackTrace = false;
-
-            testProcess.ErrorDataReceived += (sender, line) => 
+            foreach (string rawLine in result.StandardError.Split('\n'))


nit: this is a test helper, so we don't really care that much about performance, but I just want to point out that an alternative would be to use Process.ReadAllLines and avoid the need to split the captured text into separate lines:

runtime/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Multiplexing.cs

Line 146 in 46b72c7

public IEnumerable<ProcessOutputLine> ReadAllLines(TimeSpan? timeout = default)

Sth like this:

using Process testProcess = Process.Start(startInfo); foreach (ProcessOutputLine line in testProcess.ReadAllLines) { if (line.StandardError) { // the logic goes here } } testProcess.WaitForExit(); // a process can close std handles but keep running

adamsitnik · 2026-06-24T09:22:18Z

-            process.Start();
-            string output = process.StandardOutput.ReadToEnd();
-            process.WaitForExit(100); // wait for 100 ms
+            string output = Process.RunAndCaptureText(process.StartInfo).StandardOutput;


previous implementation was using timeout, pointing this out as I am not sure whether this was intentional or not

Suggested change

string output = Process.RunAndCaptureText(process.StartInfo).StandardOutput;

string output = Process.RunAndCaptureText(process.StartInfo, timeout: TimeSpan.FromMilliseconds(100)).StandardOutput;

adamsitnik · 2026-06-24T09:27:34Z

+            ProcessTextOutput result = Process.RunAndCaptureText(startInfo);
+            Console.Write(result.StandardOutput);
+            Console.Error.Write(result.StandardError);


Instead of redirecting the output and error to pipes, reading it and then writing it to parent standard output/error we can just use Process.Run. It's going to inherit the standard handles from parent and the child process is going to write directly to parent standard output/error.

Suggested change

ProcessTextOutput result = Process.RunAndCaptureText(startInfo);

Console.Write(result.StandardOutput);

Console.Error.Write(result.StandardError);

ProcessTextOutput result = Process.Run(startInfo);

adamsitnik · 2026-06-24T09:30:31Z

+string error = result.StandardError.Trim();
+if (result.ExitStatus.ExitCode != 0 || output != "Hello from HelloExe")
 {
-    Console.Error.WriteLine($"Failed to start {helloExePath}");
-    return 1;
-}
-
-Task<string> outputTask = helloExe.StandardOutput.ReadToEndAsync();
-Task<string> errorTask = helloExe.StandardError.ReadToEndAsync();
-helloExe.WaitForExit();
-string output = (await outputTask).Trim();
-string error = (await errorTask).Trim();
-if (helloExe.ExitCode != 0 || output != "Hello from HelloExe")
-{
-    Console.Error.WriteLine($"Unexpected HelloExe result. Exit code: {helloExe.ExitCode}; output: '{output}'; error: '{error}'");
+    Console.Error.WriteLine($"Unexpected HelloExe result. Exit code: {result.ExitStatus.ExitCode}; output: '{output}'; error: '{error}'");


nit: trim the error only when we need it

Suggested change

string error = result.StandardError.Trim();

if (result.ExitStatus.ExitCode != 0 || output != "Hello from HelloExe")

{

Console.Error.WriteLine($"Failed to start {helloExePath}");

return 1;

}

Task<string> outputTask = helloExe.StandardOutput.ReadToEndAsync();

Task<string> errorTask = helloExe.StandardError.ReadToEndAsync();

helloExe.WaitForExit();

string output = (await outputTask).Trim();

string error = (await errorTask).Trim();

if (helloExe.ExitCode != 0 || output != "Hello from HelloExe")

{

Console.Error.WriteLine($"Unexpected HelloExe result. Exit code: {helloExe.ExitCode}; output: '{output}'; error: '{error}'");

Console.Error.WriteLine($"Unexpected HelloExe result. Exit code: {result.ExitStatus.ExitCode}; output: '{output}'; error: '{error}'");

if (result.ExitStatus.ExitCode != 0 || output != "Hello from HelloExe")

{

string error = result.StandardError.Trim();

Console.Error.WriteLine($"Unexpected HelloExe result. Exit code: {result.ExitStatus.ExitCode}; output: '{output}'; error: '{error}'");

adamsitnik · 2026-06-24T09:33:16Z

            foreach (string key in Environment.GetEnvironmentVariables().Keys)
            {
-                process.StartInfo.EnvironmentVariables[key] = Environment.GetEnvironmentVariable(key);
+                startInfo.EnvironmentVariables[key] = Environment.GetEnvironmentVariable(key);
            }


there is no need to perform this logic, ProcessStartInfo.EnvironmentVariables is always by default initialized to parent process env vars.

It's a test app so we don't care, but when ProcessStartInfo.EnvironmentVariables is not modified at all, we can avoid allocating a lot of strings on Windows (we just let the OS know "don't use explicit env vars, just inherit all" )

adamsitnik · 2026-06-24T09:40:39Z

-            using Process checkTracefs = new() { StartInfo = checkTracefsStartInfo };
-            checkTracefs.OutputDataReceived += (_, e) =>
+            ProcessTextOutput result = Process.RunAndCaptureText(checkTracefsStartInfo);
+            foreach (string rawLine in result.StandardOutput.Split('\n'))


I think it would be better to use process.ReadAllLines here. We would avoid the need to split (and trim) and print all updates as they appear, not when they are all finished

adamsitnik · 2026-06-24T09:49:35Z

+        ProcessTextOutput result = Process.RunAndCaptureText(startInfo, TimeSpan.FromMilliseconds(DEFAULT_TIMEOUT_MS));
+        if (result.ExitStatus.Canceled)
        {
-            proc.Kill(true);
            outputWriter.WriteLine($"Timedout: '{fileName} {arguments}");
            return false;
        }


When Process.Run* APIs timeout, they kill the process and then throw TimeoutException

Suggested change

ProcessTextOutput result = Process.RunAndCaptureText(startInfo, TimeSpan.FromMilliseconds(DEFAULT_TIMEOUT_MS));

if (result.ExitStatus.Canceled)

{

proc.Kill(true);

outputWriter.WriteLine($"Timedout: '{fileName} {arguments}");

return false;

}

ProcessTextOutput result;

try

{

result = Process.RunAndCaptureText(startInfo, TimeSpan.FromMilliseconds(DEFAULT_TIMEOUT_MS));

}

catch (TimeoutException)

{

outputWriter.WriteLine($"Timedout: '{fileName} {arguments}");

return false;

}

AaronRobinsonMSFT and others added 13 commits June 23, 2026 13:55

Use Process.RunAndCaptureText in PlatformNativeR2R test

349ea41

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Use Process.RunAndCaptureText in ValidatorExe test

b560754

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Use Process.RunAndCaptureText in RFLogging WriteToReport

0b1a79b

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Use Process.RunAndCaptureText in unhandledTester

ebc69f9

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Use Process.RunAndCaptureText in stackoverflowtester

787f73c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Use Process.RunAndCaptureText in BinderTracingTest

4dd7bd6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Use Process.RunAndCaptureText in ProfilerTestRunner

7c218bd

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Use Process.RunAndCaptureText in DwarfDump test

d233256

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Convert UserEventsRequirements probes to Process.RunAndCaptureText

22570a1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Convert ReliabilityFramework result reporting to Process.RunAndCaptur…

e09ddbf

…eText Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Convert memcheck RunCommand to Process.RunAndCaptureText

019d16d

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Convert CoreclrTestWrapperLib pgrep and wmic calls to Process.RunAndC…

39e961e

…aptureText Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Convert XUnitLogChecker RunProcess to Process.RunAndCaptureText

c787659

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AaronRobinsonMSFT requested review from adamsitnik, Copilot and jkotas June 23, 2026 23:09

github-actions Bot added the area-Infrastructure-coreclr Only use for closed issues label Jun 23, 2026

github-project-automation Bot added this to Runtime Infra Jun 23, 2026

Copilot started reviewing on behalf of AaronRobinsonMSFT June 23, 2026 23:09 View session

dotnet-policy-service Bot assigned AaronRobinsonMSFT Jun 23, 2026

github-project-automation Bot added this to AppModel Jun 23, 2026

AaronRobinsonMSFT changed the title ~~Use Process.RunAndCaptureText in src/tests child-process helpers~~ Use Process.RunAndCaptureText in src/tests child-process helpers Jun 23, 2026

AaronRobinsonMSFT added test-enhancement Improvements of test source code area-Infrastructure and removed area-Infrastructure-coreclr Only use for closed issues labels Jun 23, 2026

AaronRobinsonMSFT added this to the 11.0.0 milestone Jun 23, 2026

AaronRobinsonMSFT requested a review from jkoritzinsky June 23, 2026 23:10

Copilot AI reviewed Jun 23, 2026

View reviewed changes

This was referenced Jun 24, 2026

Assertion failed '(TypeOfVN(vn) == TYP_I_IMPL) || (TypeOfVN(vn) == TYP_REF) || (TypeOfVN(vn) == TYP_BYREF)' in 'System.Runtime.Intrinsics.Arm.Sve2 #129738

Open

Assert failure: IsIL() in TryGenerateAsyncThunk #129739

Open

adamsitnik reviewed Jun 24, 2026

View reviewed changes

	string output = Process.RunAndCaptureText(process.StartInfo).StandardOutput;
	string output = Process.RunAndCaptureText(process.StartInfo, timeout: TimeSpan.FromMilliseconds(100)).StandardOutput;

Conversation

AaronRobinsonMSFT commented Jun 23, 2026

Uh oh!

dotnet-policy-service Bot commented Jun 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AaronRobinsonMSFT commented Jun 24, 2026

Uh oh!

azure-pipelines Bot commented Jun 24, 2026

Uh oh!

AaronRobinsonMSFT commented Jun 24, 2026

Uh oh!

azure-pipelines Bot commented Jun 24, 2026

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

adamsitnik Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

adamsitnik Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

adamsitnik Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

adamsitnik Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

adamsitnik Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

adamsitnik Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

adamsitnik Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants