Skip to content

feat: final parity changes with MATLAB#205

Open
john-halloran wants to merge 5 commits into
diffpy:mainfrom
john-halloran:warnings-fix
Open

feat: final parity changes with MATLAB#205
john-halloran wants to merge 5 commits into
diffpy:mainfrom
john-halloran:warnings-fix

Conversation

@john-halloran

Copy link
Copy Markdown
Contributor

This is a cleanup PR that brings parity (when other open PRs also merged) with MATLAB on a few remaining points. Since we now converge just as fast, we can use fewer iterations. We can also switch to a faster path when possible, and log the objective function.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.28%. Comparing base (d7586bc) to head (af620e2).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   77.50%   74.28%   -3.22%     
==========================================
  Files           3        3              
  Lines          40       35       -5     
==========================================
- Hits           31       26       -5     
  Misses          9        9              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments. @john-halloran I will merge, but please act on the comments if you can.

Maximum number of projected-gradient stretch steps per outer-loop
iteration. Optional.
stretch_slow_iter : int
Number of initial outer-loop stretch updates to solve with the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change any of these, but moving forward, please use the group standard that descriptions start with "The". In most cases "The" can just be added at the beginning of the existing description. But as I said, don't bother fixing this here, just use the pattern moving forward.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder, will do.

Comment thread src/diffpy/stretched_nmf/snmf_class.py
@sbillinge

Copy link
Copy Markdown
Contributor

@john-halloran this needs conflict resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants