Class reloading

[flvrone]

Sometimes when accessing enum classes from rails console - DuplicateKeyError is raised, because the class was already loaded (evaluated), but then for whatever reason it tried to load again (evaluate the whole body again), and the previous definitions are still in those instance variables, so it breaks.

Now upon including the module - the instance variable is cleared, and it does not break inheritance. (This issue #49 was already solved and tested, and my PR does not break it).

[github-actions]

Danger Report

No issues found.

View run

[dblock]

Good stuff! Update CHANGELOG and take care of my nits below?

[flvrone]

Hey @dblock, thanks for review!
I have added another test, interesting one, related to inheritance.

I believe that the documentation should be updated regarding inheritance.
As this is right now - IMO the only reliable way for it to work without errors -
is to always explicitly include Ruby::Enum in every subclass.

I think that if we want it to avoid it - that would require a different implementation and notation, probably something similar to this:
https://hanakai.org/learn/dry/dry-validation/v1.11/schemas#re-using-schemas

Notice how schemas are not explicitly defined as classes, but rather are results of some function with the given block.
And then multiple schemas are not inherited, but composed.

Also, would you please release the new version of this gem with my fix?
I would like to update it in my project. 😅

[dblock]

Merged, thank you. Please feel free to PR doc updates or a completely different implementation that solves the include problem if you think it's better and can make it work!

[dblock]

I released 1.1.0.