Skip to content

pref: improve show label button in chart display #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulleo merged 1 commit into from
Jun 24, 2026
Merged

pref: improve show label button in chart display #1224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontend/src/views/chat/answer/ChartAnswer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ function stop() {
}

const enableThousandsSeparatorList = ref<Array<string>>([])
const showLabel = ref<boolean>(false)

onBeforeUnmount(() => {
stop()
Expand All @@ -276,6 +277,7 @@ defineExpose({ sendMessage, index: () => index.value, stop })
<template>
<BaseAnswer v-if="message" :message="message" :reasoning-name="reasoningName" :loading="_loading">
<ChartBlock
v-model:show-label="showLabel"
v-model:thousands-separator-list="enableThousandsSeparatorList"
style="margin-top: 6px"
:message="message"
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/views/chat/answer/PredictAnswer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ function stop() {
}

const enableThousandsSeparatorList = ref<Array<string>>([])
const showLabel = ref<boolean>(false)

onBeforeUnmount(() => {
stop()
Expand All @@ -278,6 +279,7 @@ defineExpose({ sendMessage, index: () => index.value, chatList: () => _chatList,
<ChartBlock
v-if="message.record?.predict_data?.length > 0 && message.record?.data"
ref="chartBlockRef"
v-model:show-label="showLabel"
v-model:thousands-separator-list="enableThousandsSeparatorList"
style="margin-top: 12px"
:record-id="recordId"
Expand Down
26 changes: 18 additions & 8 deletions frontend/src/views/chat/chat-block/ChartBlock.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ const props = withDefaults(
chatType?: ChartTypes
enlarge?: boolean
loadingData?: boolean
thousandsSeparatorList?: Array<string>
thousandsSeparatorList: Array<string>
showLabel: boolean
}>(),
{
recordId: undefined,
Expand All @@ -48,14 +49,15 @@ const props = withDefaults(
enlarge: false,
loadingData: false,
thousandsSeparatorList: () => [],
showLabel: false,
}
)

const { copy } = useClipboard({ legacy: true })
const loading = ref<boolean>(false)
const { t } = useI18n()
const addViewRef = ref(null)
const emits = defineEmits(['exitFullScreen', 'update:thousandsSeparatorList'])
const emits = defineEmits(['exitFullScreen', 'update:thousandsSeparatorList', 'update:showLabel'])

const dataObject = computed<{
fields: Array<string>
Expand Down Expand Up @@ -229,8 +231,6 @@ function showSql() {
sqlShow.value = true
}

const showLabel = ref(false)

function addToDashboard() {
const recordeInfo = {
id: '1-1',
Expand Down Expand Up @@ -368,6 +368,15 @@ watch(
}
)

const _showLabel = computed({
get() {
return props.showLabel
},
set(v) {
emits('update:showLabel', v)
},
})

const enableThousandsSeparatorList = computed({
get() {
return props.thousandsSeparatorList
Expand Down Expand Up @@ -434,14 +443,14 @@ function getBaseAxis() {
<el-tooltip
effect="dark"
:offset="8"
:content="showLabel ? t('chat.hide_label') : t('chat.show_label')"
:content="_showLabel ? t('chat.hide_label') : t('chat.show_label')"
placement="top"
>
<el-button
class="tool-btn"
:class="{ 'chart-active': showLabel }"
:class="{ 'chart-active': _showLabel }"
text
@click="showLabel = !showLabel"
@click="_showLabel = !_showLabel"
>
<el-icon size="16">
<ICON_STYLE />
Expand Down Expand Up @@ -589,7 +598,7 @@ function getBaseAxis() {
:message="message"
:data="data"
:loading-data="loadingData"
:show-label="showLabel"
:show-label="_showLabel"
:thousands-separator-list="enableThousandsSeparatorList"
/>
</div>
Expand All @@ -610,6 +619,7 @@ function getBaseAxis() {
>
<ChartBlock
v-if="dialogVisible && !enlarge"
v-model:show-label="_showLabel"
v-model:thousands-separator-list="enableThousandsSeparatorList"
:message="message"
:record-id="recordId"
Expand Down
Loading