Skip to content

Delete releases.json#92

Open
dapplion wants to merge 2 commits into
masterfrom
dapplion/delete-releases-file
Open

Delete releases.json#92
dapplion wants to merge 2 commits into
masterfrom
dapplion/delete-releases-file

Conversation

@dapplion

@dapplion dapplion commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

From dappnode/DAppNodeSDK#214 releases.json should not be committed. See rationale in linked PR

tropicar
tropicar previously approved these changes Jun 2, 2022

@tropicar tropicar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablomendezroyo

Copy link
Copy Markdown
Contributor

closed by dappnode/DAppNodeSDK#214

@dapplion dapplion reopened this Jun 4, 2022
@dapplion

dapplion commented Jun 4, 2022

Copy link
Copy Markdown
Contributor Author

closed by dappnode/DAppNodeSDK#214

What do you mean? We still have to delete existing release.json files. The change in the SDK only affects future repos created with the SDK init command

@github-actions

github-actions Bot commented Jun 4, 2022

Copy link
Copy Markdown
Contributor

DAppNode bot has built and pinned the release to an IPFS node, for commit: 51b3bf9

This is a development version and should only be installed for testing purposes, install link

/ipfs/QmaWJsa9oruiSDjacbJPKdyk8fYBjyTHFdrU4H6m5bGABy

(by dappnodebot/build-action)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants