Skip to content

chore: promote dev to main — go-html v0.9.0 (Mantis #1234, audit COMPLIANT)#6

Merged
Snider merged 1 commit into
mainfrom
dev
May 1, 2026
Merged

chore: promote dev to main — go-html v0.9.0 (Mantis #1234, audit COMPLIANT)#6
Snider merged 1 commit into
mainfrom
dev

Conversation

@Snider

@Snider Snider commented May 1, 2026

Copy link
Copy Markdown
Contributor

Closes Mantis #1234.

Summary by CodeRabbit

  • Bug Fixes

    • Improved translation fallback logic to properly use the Core's i18n translator for missing translations instead of relying on generic defaults.
  • Documentation

    • Refined architecture documentation to clarify server-side translation fallback behaviour.
  • Chores

    • Removed legacy compatibility bridge package.
    • Consolidated logging and error handling utilities across internal tools.
    • Updated dependency management.

…1234)

audit.sh verdict: COMPLIANT. Build/vet/test all clean.

Closes tasks.lthn.sh/view.php?id=1234

Co-authored-by: Codex <noreply@openai.com>
@Snider Snider merged commit 74d946e into main May 1, 2026
2 of 3 checks passed
@coderabbitai

coderabbitai Bot commented May 1, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d0eb8569-ade8-4192-b249-c0dd38660e7f

📥 Commits

Reviewing files that changed from the base of the PR and between 763fc2a and eb538ac.

⛔ Files ignored due to path filters (3)
  • go.work is excluded by !**/*.work
  • go.work.sum is excluded by !**/*.sum
  • go/go.sum is excluded by !**/*.sum
📒 Files selected for processing (77)
  • .compat/core/core.go
  • .compat/core/go.mod
  • docs/architecture.md
  • go/bench_test.go
  • go/cmd/codegen/main.go
  • go/cmd/codegen/main_test.go
  • go/cmd/wasm/main.go
  • go/cmd/wasm/main_test.go
  • go/cmd/wasm/register.go
  • go/cmd/wasm/register_test.go
  • go/cmd/wasm/render_layout.go
  • go/cmd/wasm/render_layout_test.go
  • go/cmd/wasm/size_test.go
  • go/cmd/wasm/test.html
  • go/codegen/bench_test.go
  • go/codegen/codegen.go
  • go/codegen/codegen_example_test.go
  • go/codegen/codegen_test.go
  • go/codegen/doc.go
  • go/codegen/typescript.go
  • go/codegen/typescript_example_test.go
  • go/codegen/typescript_test.go
  • go/context.go
  • go/context_example_test.go
  • go/context_test.go
  • go/doc.go
  • go/edge_test.go
  • go/entitled.go
  • go/entitled_example_test.go
  • go/entitled_test.go
  • go/go.mod
  • go/grammar.go
  • go/grammar_example_test.go
  • go/grammar_test.go
  • go/integration_test.go
  • go/layout.go
  • go/layout_example_test.go
  • go/layout_test.go
  • go/node.go
  • go/node_example_test.go
  • go/node_test.go
  • go/path.go
  • go/path_example_test.go
  • go/path_test.go
  • go/pipeline.go
  • go/pipeline_example_test.go
  • go/pipeline_test.go
  • go/pkg/api/handlers.go
  • go/pkg/api/handlers_test.go
  • go/pkg/api/provider.go
  • go/pkg/api/provider_example_test.go
  • go/pkg/api/provider_test.go
  • go/render.go
  • go/render_example_test.go
  • go/render_test.go
  • go/responsive.go
  • go/responsive_example_test.go
  • go/responsive_test.go
  • go/result_default.go
  • go/result_js.go
  • go/shadow.go
  • go/shadow_example_test.go
  • go/shadow_test.go
  • go/test_helpers_test.go
  • go/text_builder_default.go
  • go/text_builder_default_example_test.go
  • go/text_builder_default_test.go
  • go/text_builder_js.go
  • go/text_builder_js_example_test.go
  • go/text_builder_js_test.go
  • go/text_translate.go
  • go/text_translate_args.go
  • go/text_translate_default.go
  • go/text_translate_js.go
  • go/wasm.go
  • go/wasm_example_test.go
  • go/wasm_test.go

📝 Walkthrough

Walkthrough

The pull request removes the .compat/core compatibility bridge package, migrates code to use core logging helpers instead of the log package, refactors translation logic to check success flags, and moves the log package to an indirect dependency.

Changes

Cohort / File(s) Summary
Compatibility Bridge Removal
.compat/core/core.go, .compat/core/go.mod
Deleted the entire compat/core package that re-aliased and re-exported types and functions from the root core package, including Action, Core, Registry[T], ServiceRuntime[T], and numerous helper functions.
Log Package Migration
go/cmd/codegen/main.go, go/cmd/wasm/register.go, go/codegen/codegen.go
Updated error and logging calls to use core.E(...), core.Warn(...), core.Error(...), and core.Info(...) instead of equivalents from the dappco.re/go/log package; removed log imports.
Dependency Management
go/go.mod
Moved dappco.re/go/log dependency from direct require block to indirect require block, maintaining version v0.8.0-alpha.1.
Translation Logic Refactoring
go/text_translate_default.go
Updated translateDefault to use i18n.Translate and check the returned OK flag before extracting the translated value; returns the original key if translation fails.
Test Simplification
go/cmd/wasm/size_test.go
Refactored test to call process.RunWithOptions directly instead of instantiating a process.Service factory and performing type assertion, reducing boilerplate.
Documentation Update
docs/architecture.md
Clarified fallback behaviour for unexported Context.service when nil: server-side translation fallback is now specified as Core's i18n translator rather than generic "global i18n.T() default".

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented May 1, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant