docs: add Solver7702Delegate docs#627
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new ChangesSolver7702Delegate Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/cow-protocol/tutorials/arbitrate/solver/driver.md`:
- Line 58: Update the wording in the sentence fragment "discarding orders that
can definitely not be settled (e.g. user is missing balances)" to improve flow
by replacing "can definitely not be settled" with "definitely cannot be settled"
or "cannot be settled" (e.g., change to "discarding orders that definitively
cannot be settled (e.g. user is missing balances)" or "discarding orders that
cannot be settled (e.g. user is missing balances)").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0b6db3ef-bbe4-447c-94a1-6b2c9ddc530b
📒 Files selected for processing (3)
docs/cow-protocol/tutorials/arbitrate/solver/driver.mddocs/cow-protocol/tutorials/solvers/onboard.mddocs/cow-protocol/tutorials/solvers/solver-7702-delegate.md
kaze-cow
left a comment
There was a problem hiding this comment.
please re-read and re-review before submitting for review again! in general the document is too long and restates things constantly, and loses track of what is important to solvers (the setup)
kaze-cow
left a comment
There was a problem hiding this comment.
reading it over again, its probably best to link any duplicated content back to the README which is in the delegation repo
930e151 to
d313bd4
Compare
|
|
||
| :::warning | ||
|
|
||
| Treat auxiliary EOAs as operationally sensitive accounts. Any approved auxiliary EOA can submit settlements through the solver EOA while the delegation is active. Keep their keys in the same security setup as the solver EOA, monitor their native-token balances, and make sure the team responsible for the solver EOA is also responsible for these accounts. |
There was a problem hiding this comment.
U still the additional accounts EOAs when they don't need to be. Lets just use a more generic name as I suggested in cowprotocol/solver-7702-delegate#5 (comment)
|
|
||
| Treat auxiliary EOAs as operationally sensitive accounts. Any approved auxiliary EOA can submit settlements through the solver EOA while the delegation is active. Keep their keys in the same security setup as the solver EOA, monitor their native-token balances, and make sure the team responsible for the solver EOA is also responsible for these accounts. | ||
|
|
||
| If an auxiliary key is compromised, rotate the delegation by configuring a new approved caller set and re-delegating from the solver EOA. |
There was a problem hiding this comment.
Let's be consistent on how you name the "auxiliary accounts" throughout the docs
|
|
||
| ::: | ||
|
|
||
| ## Reference driver setup |
There was a problem hiding this comment.
This page is called "Parallel Settlement Submission" which applies for colocated and non-collocated. I would think you should have a section for colocated ones that doesn't use the reference driver, even if this is just to link to the project's readme and mention they could get inspiration in the reference driver to implement it in theirs.
|
|
||
| # Parallel Settlement Submission | ||
|
|
||
| [`Solver7702Delegate`](https://github.com/cowprotocol/solver-7702-delegate/blob/main/src/Solver7702Delegate.sol) lets a solver keep its existing allowlisted EOA and use auxiliary EOAs as additional nonce lanes for settlement submission. |
There was a problem hiding this comment.
Should we also link the readme in the intro to parallel submissions, it has more context including the basic flow and how it works, so might fill in the reader with some missing gaps.
Co-authored-by: Anxo Rodriguez <anxolin@gmail.com>
kaze-cow
left a comment
There was a problem hiding this comment.
Unblocking myself as sufficient reviews appear to be in.
Description
Adds a solver-facing guide for using
Solver7702Delegateto keep the existing solver EOA while using auxiliary EOAs for parallel settlement submission.Changes
Solver7702Delegatetutorial under solver docs.Summary by CodeRabbit