fix(ci): add web-build job to CI — prevent broken frontend merges#270
Merged
Conversation
Frontend (web/) was never built in CI. The vite build only ran in release.yml, so syntax errors like the missing brace in TransactionDetailResponse (v0.2.0) slipped through 5 consecutive PRs. Add Web Build job: Node 22 + npm ci + npm run build in web/ directory. Also added to branch protection required status checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI
ci.ymlnever built the frontend (web/). Vite build only ran inrelease.yml, so syntax errors like the missing brace inTransactionDetailResponse(discovered during v0.2.0 release) slipped through 5 consecutive PRs undetected.Fix
web-buildjob toci.yml: Node 22 +npm ci+npm run buildrelease.ymlWeb Buildto branch protection required status checksCI Impact
+1 job (~30s) per CI run. Total: 7 required checks + Trivy/npm-audit (non-blocking).