Skip to content

Feat/charts#694

Open
mvriu5 wants to merge 6 commits into
mainfrom
feat/charts
Open

Feat/charts#694
mvriu5 wants to merge 6 commits into
mainfrom
feat/charts

Conversation

@mvriu5

@mvriu5 mvriu5 commented May 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mvriu5 mvriu5 requested a review from nicosammito May 29, 2026 03:23
@mvriu5 mvriu5 self-assigned this May 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/pictor/-/pipelines/2560714172

Status: Passed
Duration: 4 minutes

Job summaries

storybook:build

Storybook available at https://code0-tech.gitlab.io/-/development/pictor/-/jobs/14595254281/artifacts/storybook-static/index.html

Comment thread src/components/chart/Chart.tsx Outdated
Comment thread src/components/chart/Chart.tsx Outdated
Comment thread src/components/chart/Chart.tsx Outdated
Comment thread src/components/chart/Chart.tsx Outdated
Comment thread src/components/chart/Chart.tsx Outdated
Comment thread src/components/chart/Chart.tsx Outdated
color?: string
}

function ChartTooltipContent({

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why defining a custom content in the first place. Just use the rechart component and give it some styling.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant implement the same functionality & design if I use the recharts component.

Comment thread src/components/chart/Chart.tsx Outdated
nameKey?: string
}

function ChartLegendContent({

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why defining a custom content in the first place. Just use the rechart component and give it some styling.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant implement the same functionality & design if I use the recharts component.

Comment thread src/components/chart/LineChart.tsx Outdated
Comment thread src/components/chart/LineChart.tsx Outdated
legendProps?: React.ComponentProps<typeof RechartsPrimitive.Legend>
}

export function LineChart<TData extends Record<string, unknown>>({

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow standard and change to const React.FC function

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not possible because of generics.

Comment thread src/components/chart/LineChart.tsx Outdated
@mvriu5 mvriu5 requested a review from nicosammito June 23, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants