fix: detect std::atomic correctly for GCC 5+#26
Open
TrueBrain wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#ifstatement was configured too strict, preventing the detection ofstd::atomicfor GCC 5 and onward.Although I am like 99% sure the whole if-statement could be removed, as GCC 4.7 is like ... ancient. March 22, 2012, to be exact. If you like, I can just also remove the if-statement all together. For now, I just fixed what was broken :)
Full disclosure: I work for Fenris Creations, although I have no involved with the Carbon project. I work on this in my free time under my own name.