Support uki key in BLSConfig#2269
Conversation
Systemd >= v258 supports 'uki' key in bls configs. Update BLSConfig struct to reflect the same. We still support the 'efi' key for backwards compatibility During writing of the BLSConfig files we check for systemd version and use the appropriate key GrubCC does not support the 'uki' key right now See: bootc-dev#2268 Closes: bootc-dev#2263 Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Johan-Liebert1
added
the
ci/merge
|
|
||
| #[context("Querying bootctl version")] | ||
| fn bootctl_systemd_version() -> Result<u32> { | ||
| pub(crate) fn bootctl_systemd_version() -> Result<u32> { |
There was a problem hiding this comment.
This isn't new, but since we're using it more...
One issue here is that this won't do the right thing in a "sysroot" style install. We may need to do another explicit chroot style operation in the install logic.
Second, since we query this a few times, we should cache the result in a OnceLock or so
There was a problem hiding this comment.
One issue here is that this won't do the right thing in a "sysroot" style install. We may need to do another explicit chroot style operation in the install logic.
tried doing that, but bootupd fails trying to look up block device for composefs root mount. I have a fix in coreos/bootupd#1113 which I can separate out in another PR
Second, since we query this a few times, we should cache the result in a OnceLock or so
Yup. Sounds good
2 participants
Systemd >= v258 supports 'uki' key in bls configs. Update BLSConfig
struct to reflect the same. We still support the 'efi' key for
backwards compatibility
During writing of the BLSConfig files we check for systemd version and
use the appropriate key
GrubCC does not support the 'uki' key right now
See: #2268
Closes: #2263