[10.2.x] cache: apply per-volume settings on first start after clear (#13252)#13340
Open
masaori335 wants to merge 1 commit into
Open
[10.2.x] cache: apply per-volume settings on first start after clear (#13252)#13340masaori335 wants to merge 1 commit into
masaori335 wants to merge 1 commit into
Conversation
…3252) Per-volume tuning (ram_cache, ram_cache_size, ram_cache_cutoff, avg_obj_size, fragment_size) was only copied onto the CacheVol when matching an existing on-disk volume, so volumes created fresh (e.g. the first start after a cache clear) ignored the config until the next restart. Apply the settings in one pass after all CacheVols exist. Extend cache_volume_features to verify the settings take effect via per-volume metrics. (cherry picked from commit ec72cf4) Conflicts: tests/gold_tests/cache/cache_volume_features.replay.yaml
masaori335
force-pushed
the
asf-10.2.x-13252
branch
from
8ba720a to
bfdd1b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-volume tuning (ram_cache, ram_cache_size, ram_cache_cutoff, avg_obj_size, fragment_size) was only copied onto the CacheVol when matching an existing on-disk volume, so volumes created fresh (e.g. the first start after a cache clear) ignored the config until the next restart. Apply the settings in one pass after all CacheVols exist.
Extend cache_volume_features to verify the settings take effect via per-volume metrics.
(cherry picked from commit ec72cf4)
Conflicts:
tests/gold_tests/cache/cache_volume_features.replay.yaml