Throttle OCSP cert-status error instead of logging on every handshake#13312
Open
ezelkow1 wants to merge 1 commit into
Open
Throttle OCSP cert-status error instead of logging on every handshake#13312ezelkow1 wants to merge 1 commit into
ezelkow1 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts OCSP stapling logging in the TLS handshake path to reduce noisy error logs when OCSP status is unavailable/expired, aligning this message with other OCSP debug-level diagnostics in the same module.
Changes:
- Downgrade the “failed to get certificate status” log in
ssl_callback_ocsp_stapling()fromError()toDbg(dbg_ctl_ssl_ocsp, ...).
JosiahWI
previously approved these changes
Jun 23, 2026
bneradt
requested changes
Jun 23, 2026
ssl_callback_ocsp_stapling() emitted an Error on every TLS handshake when a cert's OCSP response was missing or expired, which could flood error.log. Use SiteThrottledError so ops are still alerted at Error severity but the message is rate-limited per call site (default 60s) with a suppressed-count.
bneradt
changed the title
bneradt
approved these changes
Jun 25, 2026
Member
Author
|
[approve ci fedora] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This message can get a bit spammy
PR #12951 Changed it from Debug to Error