Standardized gremlin-dotnet connection options#3468
Open
GumpacG wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3468 +/- ##
============================================
- Coverage 76.35% 75.83% -0.53%
- Complexity 13424 13650 +226
============================================
Files 1012 995 -17
Lines 60341 55471 -4870
Branches 7075 7209 +134
============================================
- Hits 46076 42067 -4009
+ Misses 11548 10822 -726
+ Partials 2717 2582 -135 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Assisted-by: Kiro: Claude Opus 4.8
a18c17d to
13e2d49
Compare
kenhuuu
reviewed
Jun 22, 2026
Timeout milliseconds DefaultBatchSize to BatchSize Removed deprecated options Assisted-by: Kiro: Claude Opus 4.8
02f5e62 to
c7264e8
Compare
Contributor
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize
gremlin-dotnetconnection optionsImplements the .NET portion of the TinkerPop 4.x GLV connection-options standardization. Renames several
ConnectionSettingsproperties and theAuthfactory methods to canonical names (old names kept as[Obsolete]deprecated aliases), aligns defaults, adds new options, and fixes two latent bugs. .NET driver changes only; the other GLVs follow in separate PRs.Proposal: https://lists.apache.org/thread/yqtr2wnb1kq2pqqq4002cz511q5o0bkg
Renames (deprecated aliases retained)
MaxConnectionsPerServerMaxConnectionsIdleConnectionTimeoutIdleTimeoutConnectionTimeoutConnectTimeoutKeepAliveIntervalKeepAliveTimeEnableCompressionCompressionAuth.BasicAuthAuth.BasicAuth.SigV4AuthAuth.Sigv4The old property names and auth methods are retained as
[Obsolete]deprecated aliases (marked "As of release 4.0.0, ...") that delegate to the canonical members, so existing code keeps compiling.Behavior changes (breaking)
ConnectTimeoutdefault lowered 15s → 5s.KeepAliveTimeis now wired to a real TCP keep-alive socket option (viaSocketsHttpHandler.ConnectCallback) rather than the inert HTTP/2 ping timeout, which had no effect on HTTP/1.1. It enablesSO_KEEPALIVEand sets the per-socket idle time on Windows, Linux, and macOS; on other platforms keep-alive stays enabled at the OS default idle time.Compressionis now a{None, Deflate}enum defaulting toDeflate(compression on by default); the driver sendsAccept-Encoding: deflateby default. SetCompression.Noneto disable. The deprecatedEnableCompressionboolis preserved only as a compatibility shim mappingtrue/falsetoCompression.Deflate/Compression.None.New options
Ssl(SslClientAuthenticationOptions) - adds client-certificate and custom-CA support.SkipCertificateValidationis applied to an internal copy rather than mutating the caller's options.DefaultBatchSize(64) - connection-level default that fills the per-requestbatchSizewhen unset.MaxResponseHeaderBytes- the maximum response header size, in bytes (converted internally to the handler's native kilobyte unit).ReadTimeout- a per-read idle timeout applied to each read of the response stream (via per-readCancelAfter).Proxy(IWebProxy) - routes connections through an HTTP proxy.GremlinServer.FromUrl(string)/GremlinServer(Uri)- configure the endpoint from a single URL (scheme, host, port, path), deriving SSL from the scheme. The existing host/port/path constructor remains.Removed (breaking)
maxResponseContentLength- responses now stream;ReadTimeoutis the partial mitigation.Bug fixes
DeflateStream(raw DEFLATE, RFC 1951) instead ofZLibStream(zlib, RFC 1950). The bug was previously masked because compression was off by default; turning it on by default would have made it a default-path failure.Ssloptions cloning (used on the skip-certificate-validation path) to copyClientCertificateContextandAllowTlsResume, which were previously dropped, breaking mTLS client certificates and silently re-enabling TLS resumption.Testing
gremlin-dotnetunit tests pass (695 tests), including newConnectionSettingsTestsand theReadTimeoutslow-read timeout test.gremlin-variants.asciidoc), and upgrade guide (release-4.x.x.asciidoc) updated for the .NET slice.Assisted-by: Kiro: Claude Opus 4.8