TEZ-4677: Upgrades Tez to compile and run with JDK 25#482
Open
maheshrajus wants to merge 1 commit into
Open
Conversation
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
It looks like the Jenkinsfile and Dockerfile have changed and been optimized in the latest commits. I need to rebase with the latest changes and check on this task. @Aggarwal-Raghav, if we want to test Tez with JDK 25, which fields in the latest Jenkinsfile and Dockerfile do we need to modify? As far as I can see in the latest changes, there are no fields related to the JDK version. |
Contributor
|
@maheshrajus , please check this.
|
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-shade-plugin</artifactId> | ||
| <version>3.6.2</version> |
Contributor
There was a problem hiding this comment.
Why this change is required? As we have moved to apache pom 37 using 3.6.1 maven shade plugin, please check if its required now after rebase
Contributor
Author
There was a problem hiding this comment.
Let me check after rebase with latest commits whether this changes is required or not. Thank you !
Contributor
Author
There was a problem hiding this comment.
i changed maven-shade-plugin version to 3.6.2 in parent pom.xml file to support JDK 25(I will push the changes after some time).
Otherwise we are getting compilations issue in tez-aux-services module.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.6.1:shade (default) on project tez-aux-services: Error creating shaded jar: Unsupported class file major version 69
maheshrajus
changed the title
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
| <maven.compiler.release>21</maven.compiler.release> | ||
| <javaVersion>25</javaVersion> | ||
| <maven.compiler.release>25</maven.compiler.release> | ||
| <version.maven-shade-plugin>3.6.2</version.maven-shade-plugin> |
Contributor
There was a problem hiding this comment.
Better to move apache parent pom to 38 as it has been released and has <version.maven-shade-plugin>3.6.2</version.maven-shade-plugin> by default
Contributor
Author
There was a problem hiding this comment.
Let me check and verify it. thanks !
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.