Skip to content

JCR-5233: commons-fileupload (1.6) restricts header size in upload pa…#357

Merged
reschke merged 2 commits into
trunkfrom
JCR-5233
Jun 25, 2026
Merged

JCR-5233: commons-fileupload (1.6) restricts header size in upload pa…#357
reschke merged 2 commits into
trunkfrom
JCR-5233

Conversation

@reschke

@reschke reschke commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

…rts - bump up the default and a system property knob

(this is a band-aid for now; in the mid term we may want to move to the servlet Part API)

@reschke
JCR-5233: commons-fileupload (1.6) restricts header size in upload pa…
e8c6265 
…rts - bump up the default and a system property knob
@reschke reschke self-assigned this Jun 12, 2026
@reschke reschke requested review from kwin and mbaedke June 13, 2026 12:59
rishabhdaim
rishabhdaim reviewed Jun 24, 2026
View reviewed changes
Comment thread jackrabbit-jcr-server/src/test/java/org/apache/jackrabbit/server/util/RequestDataTest.java
try {
System.setProperty("jackrabbit-server-PartHeaderSizeMax", "2048");
buildRequestWithFilenameOfVaryingLength(1000);
System.setProperty("jackrabbit-server-PartHeaderSizeMax", "8192");

@rishabhdaim rishabhdaim Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: the method name testMultipartPostWithExtremelyLongFilenameNButHigherConfig contains the garbled fragment NButHigher. Since this PR modifies the method body, worth fixing the name too — the sibling is testMultipartPostWithExtremelyLongFilename, so the natural counterpart is testMultipartPostWithExtremelyLongFilenameWithHigherConfig.

rishabhdaim
rishabhdaim reviewed Jun 24, 2026
View reviewed changes
Comment thread jackrabbit-jcr-server/src/test/java/org/apache/jackrabbit/server/util/RequestDataTest.java Outdated

@rishabhdaim rishabhdaim Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though not part of PR, but this method is not used, should be removed.

@reschke reschke Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, that'll be a different thing to test/fix.

@reschke
JCR-5233: commons-fileupload (1.6) restricts header size in upload pa…
a4a5bcf 
…rts - bump up the default and a system property knob
@reschke reschke requested a review from rishabhdaim June 24, 2026 13:25
@sonarqubecloud

sonarqubecloud Bot commented Jun 24, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@reschke reschke merged commit 9f8ce33 into trunk Jun 25, 2026
3 of 4 checks passed
@reschke reschke deleted the JCR-5233 branch June 25, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rishabhdaim rishabhdaim rishabhdaim approved these changes
@kwin kwin Awaiting requested review from kwin
@mbaedke mbaedke Awaiting requested review from mbaedke

Assignees

@reschke reschke

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reschke @rishabhdaim