Fix collect visualization edge styling#1651
Open
Probablism wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #556
This narrows collect edge styling in graph visualization so only the dependency annotated as
Collect[...]is drawn with the collect crow-foot. Ordinary scalar inputs into the same collect node remain normal edges.Changes
Collect[...]dependency.How I tested this
MPLCONFIGDIR=.mplconfig XDG_CACHE_HOME=.cache UV_CACHE_DIR=.uv-cache ./.uv-tools/bin/uv run pytest tests/test_graph.py -qUV_CACHE_DIR=.uv-cache ./.uv-tools/bin/uv run ruff check hamilton/graph.py tests/test_graph.pyUV_CACHE_DIR=.uv-cache ./.uv-tools/bin/uv run ruff format --check hamilton/graph.py tests/test_graph.pygit diff --checkNotes
This is limited to visualization edge styling. It does not change dynamic execution or grouping semantics.
Checklist