ScaleOutDellPlugin and ScaleOutAristaPlugin#232
Open
sunnyhe2 wants to merge 10 commits into
Open
Conversation
alexandraBara
changed the title
alexandraBara
requested changes
Jun 23, 2026
Comment on lines
+259
to
+265
| "transmitted_ok": "0", | ||
| "transmitted_drop": "0", | ||
| "received_ok": "0", | ||
| "received_drop": "0", | ||
| "tx_last_ok": "0", | ||
| "tx_last_drop": "0", | ||
| "rx_last_ok": "0", |
Collaborator
There was a problem hiding this comment.
these <>_ok fields here, wont they be non-zero?
|
|
||
| error_fields: ClassVar[dict[str, str]] = { | ||
| "oper": "up", | ||
| "speed": "400000", |
Collaborator
There was a problem hiding this comment.
will this ever change? should this be made a collector arg so we can update it at runtime?
alexandraBara
requested changes
Jun 24, 2026
alexandraBara
left a comment
alexandraBara
left a comment
Collaborator
There was a problem hiding this comment.
im also getting a pydantic validation err:
2026-06-24 11:40:21 CDT INFO nodescraper | Checking OS family
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/alexbara/node-scraper_public/nodescraper/interfaces/dataplugin.py", line 250, in _resolve_collector_args
return args_cls.model_validate(raw_args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/alexbara/node-scraper_public/venv/lib/python3.12/site-packages/pydantic/main.py", line 732, in model_validate
return cls.__pydantic_validator__.validate_python(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pydantic_core._pydantic_core.ValidationError: 1 validation error for ScaleOutAristaCollectorArgs
collection_ports
Extra inputs are not permitted [type=extra_forbidden, input_value=['1/1', '1/2'], input_type=list]
For further information visit https://errors.pydantic.dev/2.13/v/extra_forbidden
2026-06-24 11:40:21 CDT INFO nodescraper | Closing connections
2026-06-24 11:40:21 CDT INFO nodescraper | Running result collators
2026-06-24 11:40:21 CDT INFO nodescraper | Running TableSummary result collator
2026-06-24 11:40:21 CDT INFO nodescraper |
| Returns: | ||
| ``True`` if the pre-flight check passed, ``False`` otherwise. | ||
| """ | ||
| version_text = self._run_dell_command(self.CMD_VERSION) |
Collaborator
There was a problem hiding this comment.
this should err out with NOT_RAN to keep consistency with other plugins. If the part (switch) does not exist on the system. Something like:
cmd_ret = self._un_dell_command(self.CMD_VERSION)
if cmd_ret !=0:
.....
self.result.status = ExectutionStatus.NOT_RAN
....
same goes for the arista plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pytest test/unitpytest test/functional(if applicable)pre-commit run --all-filesChecklist