Fix GraphPlan: correct mutexes, interference, and level-off detection#1324
Merged
Conversation
Rework the GraphPlan engine with explicit proposition vs action mutexes, interference handling, proposition-level mutex propagation, invalid-action pruning, memoized backward solution extraction, and stronger level-off detection (state + mutex stability). Add a comprehensive tests/test_graphplan.py and curated planning environments (logistics_problem, generalized blocks_world, rush_hour, rush_hour_optimized). Existing planning tests and doctests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked, cleaned-up version of the GraphPlan fix originally proposed by @carwyn987 in #1315 (authorship of the commit is preserved). It keeps the valuable algorithmic work and adapts it to the current
masterwhile following the repo's conventions.What it does
tests/test_graphplan.py.logistics_problem, generalizedblocks_world,rush_hour,rush_hour_optimized.Differences from #1315 (kept it in AIMA style)
planning.py(no separateplanning_envs.py);from planning import *keeps working for the notebooks.predicate_negateis a module-level helper inplanning.py(the coreExprclass inutils.pyis untouched).double_tennis_problem_simple*variants;double_tennis_problem/PartialOrderPlanner left unchanged.requirements.txtkeepspytest-cov;README.mdunchanged.Tests
tests/test_graphplan.py: 34 passedtests/test_planning.py: 37 passedplanning.pydoctests: 102 passedSupersedes #1315.