Extended settings.xml - Profiles with Repo#813
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR extends the generation of the Maven settings.xml file to support an additional custom repository alongside Maven Central. Key changes include:
- Adding new constants in src/constants.ts to handle repository configuration.
- Updating authentication and settings generation functions in src/auth.ts to inject repository parameters.
- Documenting the new repository configuration and inputs in docs/advanced-usage.md and action.yml.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/constants.ts | New constants added to support custom repository parameters. |
| src/auth.ts | Updated functions to process repository configuration, including profile fallback. |
| docs/advanced-usage.md | Extended documentation to explain repository configuration usage. |
| action.yml | Added new input definitions for repository settings. |
Comments suppressed due to low confidence (1)
src/auth.ts:146
- Add tests to verify that the settings.xml is correctly generated when repository configuration parameters are provided, ensuring that the profiles are included or omitted as intended.
profiles: repoId && profileId && repoUrl ? [profiles] : [],
|
Thank you for this contribution, @Scyjin — the idea of letting I'm going to close this PR because the branch is now quite stale (April 2025) and conflicts with the recent refactor of ➡️ #1054 That issue also notes how this composes with the credentials work in #1037 (the |
Building Maven Project with dependencies of another Repository then Maven-Central.
This could be extended to support more than one repo.
Also the profile could be cut down to one overall-profile, i think.
I'm more the Backend Guy, hope its ok. :)
Description:
Extended settings.xml generation to include another Repository.
This should provide nessecary Information while building with Maven.
So your build could refer to something like Artifacts in a private github repository.
Related issue:
Check list: