Fix Boyer-Moore bad character shift to use while loop#14852
Closed
paulxg12 wants to merge 1 commit into
Closed
Conversation
The bad_character_heuristic method was reassigning the for-loop variable 'i' inside a for loop, which has no effect in Python. This caused the bad character shift to be ignored, making the algorithm behave as O(nm) brute-force instead of O(n/m). Fix: Replace for loop with while loop to allow the shift to take effect. Fixes TheAlgorithms#14844
Closing this pull request as invalid@paulxg12, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14844. Replaces for loop with while loop in bad_character_heuristic to allow the shift to take effect. All doctests pass and performance improved from 29 to 9 iterations.