fix(QTDI-3114): remove jackson test dependency#1246
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Jackson usage from component-server tests and ensures the module no longer pulls Jackson core artifacts transitively in the test classpath, aligning tests with the JSON-B (Johnzon) stack used elsewhere in the server.
Changes:
- Removed Jackson imports/usages from unit tests and switched deserialization to JSON-B.
- Simplified a test method signature by dropping an unnecessary
JsonProcessingException. - Added a Maven exclusion to prevent
com.fasterxml.jackson.core:*from being pulled via thecomponent-runtime-beamtest dependency.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/service/jcache/FrontCacheResolverTest.java | Removes Jackson exception dependency from the test method signature. |
| component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/front/SchemaTest.java | Replaces Jackson deserialization with JSON-B to avoid Jackson test dependency. |
| component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/front/EntryTest.java | Replaces Jackson deserialization with JSON-B to avoid Jackson test dependency. |
| component-server-parent/component-server/pom.xml | Excludes com.fasterxml.jackson.core:* from the component-runtime-beam test dependency transitive graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
0 New Issues
1 Fixed Issue
0 Accepted Issues
No data about coverage (0.00% Estimated after merge)
ozhelezniak-talend
approved these changes
Jun 25, 2026
ozhelezniak-talend
left a comment
ozhelezniak-talend
left a comment
Contributor
There was a problem hiding this comment.
lgtm
locall run is OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
https://qlik-dev.atlassian.net/browse/QTDI-3114
Why this PR is needed?
What does this PR adds (design/code thoughts)?
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code