Skip to content

Fixed tests failing issues #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anas-Elhounsri merged 1 commit into from
Jun 24, 2026
Merged

Fixed tests failing issues #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rsmetacheck/scripts/warnings/w004.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def detect_programming_language_no_version_pitfall(somef_data: Dict, file_name:
continue

non_versioned_languages = {
"HTML", "CSS", "JavaScript", "Shell", "Makefile",
"HTML", "CSS", "Shell", "Makefile",
"Dockerfile", "Batchfile", "PowerShell", "CMake",
}
if isinstance(lang_name, str) and lang_name in non_versioned_languages:
Expand Down
17 changes: 16 additions & 1 deletion tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def test_cli_with_generate_codemeta_adds_codemeta_output(monkeypatch, tmp_path):
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr("rsmetacheck.run_somef.subprocess.run", subprocess_run_mock)

monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)
cli_module.cli()

command = subprocess_run_mock.call_args.args[0]
Expand Down Expand Up @@ -67,6 +68,7 @@ def test_cli_without_generate_codemeta_keeps_default_behavior(monkeypatch, tmp_p
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr("rsmetacheck.run_somef.subprocess.run", subprocess_run_mock)

monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)
cli_module.cli()

command = subprocess_run_mock.call_args.args[0]
Expand Down Expand Up @@ -95,6 +97,7 @@ def test_cli_skip_somef_bypasses_somef_execution(monkeypatch, tmp_path):
)
monkeypatch.setattr(cli_module, "ensure_somef_configured", ensure_somef_mock)
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand Down Expand Up @@ -141,6 +144,7 @@ def test_cli_verbose_flag_passed_to_run_analysis(monkeypatch, tmp_path):
],
)
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand All @@ -163,8 +167,9 @@ def test_cli_verbose_defaults_to_false(monkeypatch, tmp_path):
str(somef_file),
"--skip-somef",
],
)
) # test_cli_verbose_defaults_to_false
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand Down Expand Up @@ -194,6 +199,7 @@ def test_cli_branch_passed_to_somef(monkeypatch, tmp_path):
monkeypatch.setattr(cli_module, "ensure_somef_configured", lambda: True)
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr("rsmetacheck.run_somef.subprocess.run", subprocess_run_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand Down Expand Up @@ -224,6 +230,7 @@ def test_cli_threshold_passed_to_somef(monkeypatch, tmp_path):
monkeypatch.setattr(cli_module, "ensure_somef_configured", lambda: True)
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr("rsmetacheck.run_somef.subprocess.run", subprocess_run_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand Down Expand Up @@ -252,6 +259,7 @@ def test_cli_notes_output_passed_to_run_analysis(monkeypatch, tmp_path):
],
)
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand Down Expand Up @@ -279,6 +287,7 @@ def test_cli_custom_pitfalls_output_dir(monkeypatch, tmp_path):
],
)
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand Down Expand Up @@ -306,6 +315,7 @@ def test_cli_custom_analysis_output_path(monkeypatch, tmp_path):
],
)
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand Down Expand Up @@ -333,6 +343,7 @@ def test_cli_custom_somef_output_dir(monkeypatch, tmp_path):
monkeypatch.setattr(cli_module, "ensure_somef_configured", lambda: True)
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr(cli_module, "run_somef_single", run_somef_single_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand All @@ -358,6 +369,7 @@ def test_cli_input_url_triggers_run_somef_single(monkeypatch):
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr(cli_module, "run_somef_single", run_somef_single_mock)
monkeypatch.setattr(cli_module, "run_somef_batch", run_somef_batch_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand Down Expand Up @@ -386,6 +398,7 @@ def test_cli_input_file_triggers_run_somef_batch(monkeypatch, tmp_path):
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr(cli_module, "run_somef_single", run_somef_single_mock)
monkeypatch.setattr(cli_module, "run_somef_batch", run_somef_batch_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand Down Expand Up @@ -436,6 +449,7 @@ def test_cli_multiple_inputs_triggers_multiple_calls(monkeypatch, tmp_path):
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr(cli_module, "run_somef_single", run_somef_single_mock)
monkeypatch.setattr(cli_module, "run_somef_batch", run_somef_batch_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand Down Expand Up @@ -505,6 +519,7 @@ def test_cli_config_profile_forwarded_to_run_analysis(monkeypatch, tmp_path):
)
monkeypatch.setattr(cli_module, "load_analysis_config", load_config_mock)
monkeypatch.setattr(cli_module, "run_analysis", run_analysis_mock)
monkeypatch.setattr(cli_module, "_exit_on_findings", lambda *a: None)

cli_module.cli()

Expand Down
Loading