Skip to content

Fixes for #98 and #99 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anas-Elhounsri merged 1 commit into from
Jun 24, 2026
Merged

Fixes for #98 and #99 #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rsmetacheck/scripts/warnings/w001.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def detect_unversioned_requirements(somef_data: Dict, file_name: str) -> Dict:

result["total_requirements"] = total_reqs
result["unversioned_count"] = unversioned_count
result["unversioned_requirements"] = unversioned_names
result["unversioned_requirements"] = list(dict.fromkeys(unversioned_names))

if total_reqs > 0:
result["percentage_unversioned"] = round((unversioned_count / total_reqs) * 100, 2)
Expand Down
9 changes: 8 additions & 1 deletion src/rsmetacheck/scripts/warnings/w004.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,16 @@ def detect_programming_language_no_version_pitfall(somef_data: Dict, file_name:
if isinstance(lang_name, str) and _name_contains_version(lang_name):
continue

non_versioned_languages = {
"HTML", "CSS", "JavaScript", "Shell", "Makefile",
"Dockerfile", "Batchfile", "PowerShell", "CMake",
}
if isinstance(lang_name, str) and lang_name in non_versioned_languages:
continue

result["programming_languages_without_version"].append(lang_name)
result["source"] = source
result["has_warning"] = True
result["has_warning"] = True

if "requirements" in somef_data:
requirements_entries = somef_data["requirements"]
Expand Down
Loading