[Performance] Memoize hasGit check in cli-kit#7954
Conversation
Memoizes the result of `hasGit()` using a module-level promise to eliminate redundant process spawns of `git --version` during CLI execution. Includes a `_resetHasGit()` utility for test isolation.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/context/local.d.ts@@ -132,6 +132,11 @@ export declare function cloudEnvironment(env?: NodeJS.ProcessEnv): {
* @returns A promise that resolves with the value.
*/
export declare function hasGit(): Promise<boolean>;
+/**
+ * Resets the memoized hasGit value.
+ * This is useful for testing.
+ */
+export declare function _resetHasGit(): void;
/**
* Gets info on the CI platform the CLI is running on, if applicable.
*
|
WHY are these changes introduced?
The
hasGitfunction incli-kitexecutesgit --versionevery time it's called. Spawning a child process is relatively expensive. In commands that perform multiple environment checks or analytics collection, this redundant execution can measurably slow down the CLI.WHAT is this pull request doing?
Memoizes the result of
hasGit()using a module-level promise. This ensures thatgit --versionis executed at most once during the CLI's execution. Subsequent calls will return the cached result.Includes an exported
_resetHasGit()utility to maintain test isolation.How to test your changes?
CI
Checklist
pnpm changeset addPR created automatically by Jules for task 9108386419192763021 started by @gonzaloriestra