[Performance] Memoize hasGit check

packages/cli-kit/src/public/node/context/local.test.ts

@@ -1,6 +1,7 @@
 import {
   ciPlatform,
   hasGit,
+  _resetHasGit,
   isDevelopment,
   isShopify,
   isTerminalInteractive,
@@ -125,6 +126,7 @@ describe('isShopify', () => {
 describe('hasGit', () => {
   test('returns false if git --version errors', async () => {
     // Given
+    _resetHasGit()
     vi.mocked(exec).mockRejectedValue(new Error('git not found'))
 
     // When
@@ -136,6 +138,7 @@ describe('hasGit', () => {
 
   test('returns true if git --version succeeds', async () => {
     // Given
+    _resetHasGit()
     vi.mocked(exec).mockResolvedValue(undefined)
 
     // When
@@ -144,6 +147,21 @@ describe('hasGit', () => {
     // Then
     expect(got).toBeTruthy()
   })
+
+  test('memoizes the result', async () => {
+    // Given
+    _resetHasGit()
+    vi.mocked(exec).mockResolvedValue(undefined)
+
+    // When
+    await hasGit()
+    await hasGit()
+    const got = await hasGit()
+
+    // Then
+    expect(got).toBeTruthy()
+    expect(vi.mocked(exec)).toHaveBeenCalledTimes(1)
+  })
 })
 
 describe('analitycsDisabled', () => {

packages/cli-kit/src/public/node/context/local.ts

@@ -231,19 +231,40 @@ export function cloudEnvironment(env: NodeJS.ProcessEnv = process.env): {
   return {platform: 'localhost', editor: false}
 }
 
+/**
+ * Memoized promise for the hasGit check.
+ */
+let hasGitPromise: Promise<boolean> | undefined
+
 /**
  * Returns whether the environment has Git available.
  *
  * @returns A promise that resolves with the value.
  */
-export async function hasGit(): Promise<boolean> {
-  try {
-    await lazyExec('git', ['--version'])
-    return true
-    // eslint-disable-next-line no-catch-all/no-catch-all
-  } catch {
-    return false
+export function hasGit(): Promise<boolean> {
+  if (hasGitPromise) {
+    return hasGitPromise
   }
+
+  hasGitPromise = (async () => {
+    try {
+      await lazyExec('git', ['--version'])
+      return true
+      // eslint-disable-next-line no-catch-all/no-catch-all
+    } catch {
+      return false
+    }
+  })()
+
+  return hasGitPromise
+}
+
+/**
+ * Resets the memoized value for the hasGit check.
+ * This is only intended for use in tests.
+ */
+export function _resetHasGit(): void {
+  hasGitPromise = undefined
 }
 
 /**