LoginActivity Compose 전환 및 테스트 추가#401
Conversation
|
Warning Review limit reached
More reviews will be available in 37 minutes and 2 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
작업 배경
변경 사항
LoginActivityBindingActivity/XML 바인딩 제거,setContent기반LoginScreen렌더링으로 전환LoginScreenLoginViewModelclearErrorMessage()추가activity_login.xmlLoginUiStateTest,LoginViewModelTest,LoginScreenTest영향 범위
검증 매트릭스
로그인_버튼과_방문자_모드가_노출된다각_버튼을_누르면_대응하는_콜백이_호출된다loginState가_Loading이면_isLoading은_true다•
로딩_상태면_인디케이터가_노출된다postLogin 성공 시 loginResult와 Success 상태로 갱신된다postLogin 실패 시 errorMessage와 Failure 상태로 갱신된다•
errorMessage는_그대로_전달된다clearErrorMessage는_errorMessage를_null로_초기화한다Before / After 영상
login_before.mp4
login_after.mp4
Splash 진입 후 LoginActivity 화면이 노출되는 동일 플로우를 비교했습니다.
로그인 상호작용 검증 영상
login_after_google_click_proof.mp4
login_after_kakao_click_proof.mp4
login_after_visitor_mode.mp4
Test Plan
JAVA_HOME=/Users/unamkim/Library/Java/JavaVirtualMachines/temurin-19.0.2/Contents/Home ./gradlew testDebugUnitTest --tests 'com.runnect.runnect.presentation.login.*'— Login 유닛 테스트 6/6 통과JAVA_HOME=/Users/unamkim/Library/Java/JavaVirtualMachines/temurin-19.0.2/Contents/Home ./gradlew clean assembleDebug— debug 빌드 성공JAVA_HOME=/Users/unamkim/Library/Java/JavaVirtualMachines/temurin-19.0.2/Contents/Home ./gradlew connectedDebugAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=com.runnect.runnect.presentation.login.LoginScreenTest— Compose UI 테스트 3/3 통과