Skip to content

Revert "test: ViewModel unit test 인프라 추가 및 첫 테스트 작성"#398

Closed
unam98 wants to merge 1 commit into
developfrom
revert-391-test/add-viewmodel-unit-test-infra
Closed

Revert "test: ViewModel unit test 인프라 추가 및 첫 테스트 작성"#398
unam98 wants to merge 1 commit into
developfrom
revert-391-test/add-viewmodel-unit-test-infra

Conversation

@unam98

@unam98 unam98 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Reverts #391

Summary by CodeRabbit

  • Tests
    • Removed several unit tests related to visitor mode and profile screen behavior.
  • Chores
    • Cleaned up test dependency settings by removing unused testing libraries.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8bfdac74-97d6-4013-ac72-11b972be794c

📥 Commits

Reviewing files that changed from the base of the PR and between 3abad2d and 74e7804.

📒 Files selected for processing (4)
  • app/build.gradle
  • app/src/test/java/com/runnect/runnect/presentation/event/VisitorModeManagerTest.kt
  • app/src/test/java/com/runnect/runnect/presentation/mypage/MyPageViewModelTest.kt
  • gradle/libs.versions.toml
💤 Files with no reviewable changes (4)
  • app/src/test/java/com/runnect/runnect/presentation/event/VisitorModeManagerTest.kt
  • app/build.gradle
  • gradle/libs.versions.toml
  • app/src/test/java/com/runnect/runnect/presentation/mypage/MyPageViewModelTest.kt

📝 Walkthrough

Walkthrough

The PR removes MockK, Turbine, and kotlinx.coroutines.test from the version catalog and app test dependency declarations. It also deletes unit tests for VisitorModeManager and MyPageViewModel.

Changes

Test dependency removal

Layer / File(s) Summary
Version catalog cleanup
gradle/libs.versions.toml
The [versions] section removes MockK and Turbine references, and the [libraries] section removes MockK, Turbine, and kotlinx.coroutines.test entries.
App module dependency removal
app/build.gradle
The dependencies block removes the matching local unit test testImplementation entries, leaving only libs.junit before androidTestImplementation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

Poem

I nibbled the old test hay away,
and hopped as mockk went out to play.
Turbine drifted past the moonlit mound,
while tidy builds made a softer sound.
🐰🌙

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly indicates a revert of the earlier test-infra change, matching the removed test files and test dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-391-test/add-viewmodel-unit-test-infra

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@unam98

unam98 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

PR #391이 이미 develop에 머지됐고, 그 위에 #392(Storage Compose 전환 + 테스트)까지 쌓여 있어서 revert 불필요. 닫음.

@unam98 unam98 closed this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant