Conversation
By "some of these files that are being removed" do you mean these two? I didn't go into the code of every removed file. create_apache_config.sh.deploy Those were the two I found referenced in workflows. I'm not sure off the top of my head what's calling these on the server once things start, but the apache restart is probably still wanted with codedeploy? Otherwise, I think these make sense, but we'll want to wait to merge until deploys are changed? |
|
Yeah those are the two. I've just worked through the four repos where those two scripts were being referenced in workflows and removed them. They're not actually used in deploys, they were just getting env variables substituted and copied. |
With one exception, these scripts are used exclusively by CodeDeploy to deploy Django and JS applications.
make_zip_djangois the only script that is used directly by a GitHub Workflow. I think we could potentially get rid of that one too by replacing the run commands in the workflows it's used in with the code it calls.Another note: some of these files that are being removed are referenced in GH Workflows where env substitution happens (even though the final files are not used for anything) so those workflows will fail unless those references are also removed.