Refactored git_strarray_wrapper#171
Open
JohanMabille wants to merge 2 commits into
Open
Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 88.39% 86.56% -1.84%
==========================================
Files 62 63 +1
Lines 2974 2992 +18
Branches 373 372 -1
==========================================
- Hits 2629 2590 -39
- Misses 345 402 +57 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
SandrineP
reviewed
Jun 24, 2026
| // Tags | ||
| // git_strarray_wrapper tag_list_match(std::string pattern); | ||
| // strarray_view_wrapper tag_list_match(std::string pattern); | ||
| std::vector<std::string> tag_list_match(std::string pattern); |
Collaborator
There was a problem hiding this comment.
Wasn't this a placeholder to be replaced by the line above after this refactoring ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108
This renames the
git_strarray_wrapperclass intostrarray_view_wrapperand adds thestrarray_owned_wrapperclass.