feat: add set_start_time and set_end_time to V1 timer traits#856
Open
allenporter wants to merge 2 commits into
Open
feat: add set_start_time and set_end_time to V1 timer traits#856allenporter wants to merge 2 commits into
allenporter wants to merge 2 commits into
Conversation
Lash-L
reviewed
Jun 26, 2026
|
|
||
| async def set_end_time(self, end_time: datetime.time) -> None: | ||
| """Set the end time of the Do Not Disturb (DND) timer.""" | ||
| timer = DnDTimer( |
Collaborator
There was a problem hiding this comment.
should we be checking if by chance self.start_hour or minute is None here? That's the root of the bug Paulus was having right? same thing above?
Contributor
Author
There was a problem hiding this comment.
OK, sure. Once we check them for None what are you expecting to happen? Send in zeros or nulls? (i believe this is current behavior) or send nothing? lie to the caller and set end time on the trait without sending the RPC?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose new methods on V1 timer traits to update quiet/off-peak start and end times directly with datetime.time objects.