Tree and item skill tooltips#9892
Open
vaisest wants to merge 41 commits into
Open
Conversation
- adding a type hint for new() and newClass() - adding simple ---@Class x: y type hints for base class variables
… being an argument to newClass
…`) to fix type checking
…f using new() and varargs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Ports tree tooltips from PathOfBuildingCommunity/PathOfBuilding-PoE2#1969, although the tooltip code is mostly as it was in pob1.
Also ports item tooltips from PathOfBuildingCommunity/PathOfBuilding-PoE2#2208. I'm not sure this was done correctly. In pob2 I found a skill gem for each item skill, but in pob1 I couldn't, which means the skill tooltips don't have tags etc. These are shown when shift is held.
"Socketed gems are supported by #" mods are also included in the tooltips.
Flavour text was also added. Credit for the code goes to Blitz54 in PoB2
Quality ranges and level ranges were NOT added as it seems like the tree and items always grant the same level, and there's afaik no way to add quality to them.
Steps taken to verify a working solution:
I think the core functionality is working properly, but there are little things like tooltip positioning and gaps which are frankly sometimes complete nonsense and a massive pain in the ass. These might still be wrong. For example the height received from GetSize just doesn't match up and produces different-sized gaps for different tooltips.
I'm also not sure if there could be some style changes similar to what @Blitz54 did in PathOfBuildingCommunity/PathOfBuilding-PoE2#1992.
Note that this is based on the typing PR.
Link to a build that showcases this PR:
Item database
Before screenshot:
After screenshot: