Add init container and scope-based env-var partitioning#304
Merged
Conversation
When a RunnerJob carries InitCommands, schedule a second init container
that runs those commands in the job image before the main container
starts. Variables on the job can carry a Scope ("init" or "main") that
limits which container sees them — unscoped variables go to both.
The init container shares a new "workspace" emptyDir volume with the
main container at WorkingDir, so the init phase can clone a repo and
the main container picks it up. This lets the OpenCode coding-agent
hold REPO_CLONE_URL inside the init container only, so the agent
container never sees the OAuth token in its env.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jasonopslevel
approved these changes
Jun 30, 2026
jasonopslevel
left a comment
jasonopslevel
left a comment
Contributor
There was a problem hiding this comment.
looks great! Cleaner than i thought it would be too :)
| } | ||
|
|
||
| if len(job.InitCommands) > 0 { | ||
| initContainers = append(initContainers, s.getInitContainer(job, containerSecurityContext)) |
Contributor
There was a problem hiding this comment.
in theory we could make the helper container conditional too, only SBOM jobs use it
opslevel-go v2026.6.30 brings the InitCommands, InitImage, and RunnerJobVariable.Scope fields the runner now depends on. Its release also pulls in newer versions of golangci-lint plugin packages (goconst, nakedret, unconvert) whose APIs are incompatible with golangci-lint v1.64.8. Upgrade golangci-lint to v2.1.2 to match. The v2 linter enables staticcheck's ST* (style) and QF* (quick-fix) rule families by default, which v1 had off. Disable the specific checks that flag pre-existing code so this is a clean tooling bump rather than a code-style sweep. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
derek-etherton-opslevel
force-pushed
the
startup-commands-and-scope
branch
from
1dafdcb to
b28ca1e
Compare
Contributor
Author
|
heads up @jasonopslevel, I had to upgrade |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a RunnerJob carries InitCommands, schedule a second init container that runs those commands in the job image before the main container starts. Variables on the job can carry a Scope ("init" or "main") that limits which container sees them — unscoped variables go to both.
The init container shares a new "workspace" emptyDir volume with the main container at WorkingDir, so the init phase can clone a repo and the main container picks it up.
Follow up to: OpsLevel/opslevel-go#624 <- CI will fail till we release this and bump in this PR.