Fix Seeed E1003 BLE upload hang and 4bpp white background#48
Open
davelee98 wants to merge 1 commit into
Open
Conversation
…cheme for bootscreen routine, fixing white background for 4bpp gray. Used the new named #DEFINE constants for color_Scheme everwhere there were magic numbers. Also fixed bug since 1.73 where SEEED E1003 panels (display type 3000/3001) were getting stuck and never updating on BLE update due to reset pin being held low due to power saving and causing timesouts.
Contributor
Author
|
fixed two separate issues as per claude. more complete fix on dealing with the white background on 4bpp panel, but generalized to all color schemes. Also fixed E1003 not working from 1.73 onwards due to power saving logic failing on SEEED driver branch (when combined with 10" panel.) Need to make sure this doesn't break anything else, (it shouldn't.) as it shouldn't touch the NRF driver path. |
Contributor
Author
|
probably need to also test whether power saving still works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configureDisplayPinsLowPower()drove RST LOW unconditionally duringpwrmgm(false). On Seeed E1003 panels (types 3000/3001) with nopwr_pin, the IT8951 TCON stays powered viaite_enable/tft_enable. RST LOW puts the IT8951 into hardware reset, holding BUSY LOW. ThetconWaitForReady()call insidewake()at the start of every BLE upload then blocked for the full 15-second timeout — long enough for the BLE connection to drop before the initial ACK was sent. Fix: gateconfigureDisplayPinsLowPower()onpwr_pin != 0xFF(no power rail being cut = no reason to drive lines low), and add RST de-assertion to the Seeedpwrmgm(true)branch for devices that do have a power pin.kSchemeWhiteValueto enumerate the correct white pixel value per color scheme for the boot screen. Replaced magic numbers with named constants forcolor_schemethroughout.Test plan
0x00 0x70received within 1 second of upload start commandpwr_pinset (configureDisplayPinsLowPowerstill runs for those)🤖 Generated with Claude Code