compose-order: drop the closed #2, keep the generated shape (#16)#26
Open
estebanzimanyi wants to merge 1 commit into
Open
Conversation
…MobilityDB#16) PR MobilityDB#2 (feat/shape-metadata, hand-maintained shape in meta/meos-meta.json) was closed, superseded by MobilityDB#16 which generates the shape (arrayReturn/outputArrays/ nullable) from the C signatures + Doxygen across all functions, with meos-meta.json kept as an override layer. Remove the closed MobilityDB#2 from the composing set, sharpen MobilityDB#16's role, and record the supersession.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Aligns the committed
tools/pin/compose-order.txtmanifest with the supersession noted on #2 (#2 (comment)).PR #2 (
feat/shape-metadata, hand-maintained shape inmeta/meos-meta.json) was closed, superseded by #16, which generates the shape (arrayReturn/outputArrays/nullable) from the C signatures + Doxygen (parser/shapeinfer.py+nullable.py) across all functions, withmeos-meta.jsonretained only as an override layer. (#2 was also based on the closedfix/stdbool-stub#1, so unmergeable to master.)This manifest still listed the now-closed #2 as a composing PR. This:
meos-meta.jsonas override),SUPERSEDEDfooter note.Content-preserving — no shape data is lost (anything #16 can't infer stays in
meos-meta.jsonas an override). Manifest-only change; no build impact.Verified this turn: of all 17 manifest entries, only #2 is CLOSED; #16 is OPEN and generates the shape.