Support bigint#126
Open
bbimber wants to merge 5 commits into
Open
Conversation
cnathe
reviewed
Jun 24, 2026
Contributor
Author
|
@cnathe: I think the current changes should pass for you. the query API tests are working locally for me. |
Contributor
Yes, that works much better. I think this approach to "only use bigint when needed" makes sense for this first pass. Thanks. |
cnathe
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to this ticket: https://www.labkey.org/ONPRC/Support%20Tickets/issues-details.view?issueId=54682
I dont recall how LabKey does testing on RLabkey; however, it would be a good idea to add a test case with some kind of large integer (e.g., 3.157524392E9) and SelectRows.