Skip to content

fix(rank): Document History 列表加滚动,修内容溢出 (#358)#360

Merged
longsizhuo merged 2 commits into
mainfrom
fix/rank-doc-history-scroll
Jun 28, 2026
Merged

fix(rank): Document History 列表加滚动,修内容溢出 (#358)#360
longsizhuo merged 2 commits into
mainfrom
fix/rank-doc-history-scroll

Conversation

@longsizhuo

Copy link
Copy Markdown
Member

问题

Rank 页贡献者弹窗的 Document History 列表没有滚动,文档多时内容溢出弹窗(#358)。

根因

ContributorRow.tsxDialog.Content className 同时写了 gridflex col

  • gridflex 都设 display,Tailwind 级联里 grid 胜出 → flex 列容器从未生效;
  • col 不是合法 Tailwind class(no-op);
  • 即便 flex 生效,滚动子容器的 min-h-[150px] 也会阻止收缩到滚动。

修复

  • Dialog.Contentgrid … flex colflex flex-col
  • 滚动子容器:min-h-[150px]min-h-0(flex 子项默认 min-height:auto 阻止收缩,min-h-0 才能让 overflow-y-auto 生效)

这是 flex 滚动的标准写法。空状态由 flex-grow 撑开,不受影响。

验证

  • 逐层 trace flex 链:Dialog.Content(flex-col, max-h-[85vh]) → header(shrink-0) → 滚动区(flex-grow min-h-0 overflow-y-auto)。
  • 对抗式 review 复核为 canonical scroll pattern,旧标记确为三重 bug。
  • pre-commit 全量测试 52 passed。

Closes #358

🤖 Generated with Claude Code

Dialog.Content 的 className 同时写了 `grid` 和 `flex col`:grid/flex 都设 display
(Tailwind 级联里 grid 胜出),且 `col` 不是合法 class,flex 列容器从未生效,
Document History 列表无法滚动、内容溢出弹窗。

改为 `flex flex-col`,并把滚动子容器的 `min-h-[150px]` 换成 `min-h-0`
(flex 子项默认 min-height:auto 会阻止收缩,min-h-0 才能让 overflow-y-auto 生效)。

Closes #358

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
involutionhell-github-io Ready Ready Preview, Comment Jun 27, 2026 11:59pm
website-preview Ready Ready Preview, Comment Jun 27, 2026 11:59pm

doc-title span 是 flex 子项,truncate 需配 min-w-0 才生效(flex 子项默认
min-width:auto 不收缩)。否则超长标题横向溢出、把外链图标挤出、撑破 max-w-lg 弹窗。
列表加滚动后长列表可达,此问题更易触发。

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@longsizhuo longsizhuo merged commit 09840bf into main Jun 28, 2026
7 checks passed
@longsizhuo longsizhuo deleted the fix/rank-doc-history-scroll branch June 28, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Rank中个人贡献document history列表没有做滚动,内容溢出

1 participant