fix(rank): Document History 列表加滚动,修内容溢出 (#358)#360
Merged
Conversation
Dialog.Content 的 className 同时写了 `grid` 和 `flex col`:grid/flex 都设 display (Tailwind 级联里 grid 胜出),且 `col` 不是合法 class,flex 列容器从未生效, Document History 列表无法滚动、内容溢出弹窗。 改为 `flex flex-col`,并把滚动子容器的 `min-h-[150px]` 换成 `min-h-0` (flex 子项默认 min-height:auto 会阻止收缩,min-h-0 才能让 overflow-y-auto 生效)。 Closes #358 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
doc-title span 是 flex 子项,truncate 需配 min-w-0 才生效(flex 子项默认 min-width:auto 不收缩)。否则超长标题横向溢出、把外链图标挤出、撑破 max-w-lg 弹窗。 列表加滚动后长列表可达,此问题更易触发。 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Rank 页贡献者弹窗的 Document History 列表没有滚动,文档多时内容溢出弹窗(#358)。
根因
ContributorRow.tsx的Dialog.ContentclassName 同时写了grid和flex col:grid与flex都设display,Tailwind 级联里grid胜出 → flex 列容器从未生效;col不是合法 Tailwind class(no-op);min-h-[150px]也会阻止收缩到滚动。修复
Dialog.Content:grid … flex col→flex flex-colmin-h-[150px]→min-h-0(flex 子项默认min-height:auto阻止收缩,min-h-0才能让overflow-y-auto生效)这是 flex 滚动的标准写法。空状态由
flex-grow撑开,不受影响。验证
Dialog.Content(flex-col, max-h-[85vh]) → header(shrink-0) → 滚动区(flex-grow min-h-0 overflow-y-auto)。Closes #358
🤖 Generated with Claude Code