Align with numpy 2.5#137
Open
antonwolfy wants to merge 3 commits into
Open
Conversation
…est.warns(DeprecationWarning) in the tests
antonwolfy
requested review from
jharlow-intel,
ndgrigorian and
xaleryb
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy 2.5 introduced two deprecations that broke the
mkl_randomtest suite (2 failures, plus deprecation warnings emitted across many tests). This PR resolves both:In-place array
shapeassignment — NumPy 2.5 deprecated settingarr.shape = (...)in place. Replaced all such sites inmkl_random/mklrand.pyxwith the equivalentarr.reshape((...)). The affected arrays are freshly-allocated C-contiguous buffers, soreshapereturns a view (no copy) and behavior is unchanged.np.reshape(..., copy=False)was intentionally avoided since the package supportsnumpy >=1.26.4and thecopykwarg only landed in NumPy 2.1.numpy.testing.suppress_warnings— deprecated in NumPy 2.4. Replaced the two usages inmkl_random/tests/test_random.pywithpytest.warns(DeprecationWarning)and removed the now-unused import. The tests still assert thatrandom_integersemits aDeprecationWarning.