Skip to content

feat(dialtesting): add SSL task and sanitize browser runner errors#192

Merged
coanor merged 14 commits into
GuanceCloud:mainfrom
zhengb-gc:fix-dialtesting-lightpanda-error-message
Jun 17, 2026
Merged

feat(dialtesting): add SSL task and sanitize browser runner errors#192
coanor merged 14 commits into
GuanceCloud:mainfrom
zhengb-gc:fix-dialtesting-lightpanda-error-message

Conversation

@zhengb-gc

Copy link
Copy Markdown
Contributor

Summary

This PR improves dialtesting browser runner error handling and adds a new SSL dial testing task.

Browser dial testing

  • Sanitize browser runner errors before reporting dialtesting results.
  • Replace Lightpanda/Chrome runner startup failures with a generic user-facing message:
    Browser dial testing system error, please check agent logs
  • Prevent environment details from leaking through fail_reason, message, step errors, or retry records.
  • Keep actionable non-runner errors unchanged, including script errors, assertion failures, selector failures, and browser config errors.
  • Log the original sanitized runner error to agent logs for troubleshooting.

SSL dial testing

  • Add SSLTask and register the ssl / SSL task type.
  • Support TLS connection checks with host, port, optional SNI server name, timeout, and optional certificate verification skip.
  • Report SSL result fields including:
    • response_time
    • tls_handshake_time
    • tls_version
    • ssl_cert_not_before
    • ssl_cert_not_after
    • ssl_cert_expires_in_days
    • ssl_cert_subject
    • ssl_cert_issuer
  • Support success rules for response time, certificate expiry, certificate not-after timestamp, subject, issuer, and TLS version.
  • Support and / or success logic.
  • Support template rendering for SSL host, port, server name, and success rule options.

Other

  • Change the default dialtesting logger name from icmp to dialtesting.

Testing

  • Added browser error handling tests covering:
    • runner error sanitization
    • retry record sanitization
    • preservation of non-runner errors
    • preservation of browser config errors
  • Added SSL task tests covering:
    • task creation and registration
    • validation and initialization errors
    • TLS run success and failure paths
    • certificate metadata extraction
    • TLS handshake time reporting
    • success rule evaluation
    • template rendering

@coanor coanor merged commit d4c5e91 into GuanceCloud:main Jun 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants