Removes two entry points for memory leaks#182
Merged
Conversation
Makes Token.prev a weak var preventing retention if a cyclec occur in the graph. ValidationContext no longer captures itself strongly in assigning onError; uses an override of report instead. Regression tests were added to validate the fixes
jwsinner
changed the title
NeedleInAJayStack
requested changes
Jun 24, 2026
NeedleInAJayStack
left a comment
NeedleInAJayStack
left a comment
Member
There was a problem hiding this comment.
Thanks! Great find, and thanks for contributing these fixes!
NeedleInAJayStack
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Token.prevto be a weak var to prevent memory leaks caused by reference cycles in the AST.Updates
ValidationContextto use an override ofreport(error: GraphQLError)rather than capturing itself strongly in theonErrorclosure.Adds
GraphQLMemoryRetentionTests.swiftwith two regression tests to validate these changes remove these leaks.