Skip to content

Add Hermes Tweet trust record#115

Open
kriptoburak wants to merge 1 commit into
GoPlusSecurity:mainfrom
kriptoburak:codex/add-hermes-tweet-agentguard-trust
Open

Add Hermes Tweet trust record#115
kriptoburak wants to merge 1 commit into
GoPlusSecurity:mainfrom
kriptoburak:codex/add-hermes-tweet-agentguard-trust

Conversation

@kriptoburak

Copy link
Copy Markdown
Contributor

Summary

  • Add Hermes Tweet v0.1.6 to the AgentGuard trust registry.
  • Mark it as restricted with no filesystem access, no command execution, and a single public network host.
  • Bind the record to an AgentGuard-compatible directory artifact hash for the released Hermes Tweet skill.

Eligibility

Validation

  • jq registry shape and record-key check
  • git diff --check
  • Public evidence link checks for the release and skill file
  • npm ci completed; it reports 13 existing dependency audit findings
  • npm run build
  • npm test (415 passing)

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown

AgentGuard PR Review

  1. medium — data/registry.json hunk

    • The new registry entry is trusted solely based on a single commit/hash reference, but there is no evidence in the diff that the referenced artifact hash is independently verified against the fetched package contents at install/use time.
    • What can go wrong: a mismatched or replaced artifact under the same tag/commit could be treated as trusted, allowing an unintended skill payload to be approved.
    • Fix: enforce verification that the resolved package contents exactly match artifact_hash before activating the record, and reject any tag/commit resolution that does not match the recorded hash.
  2. low — data/registry.json hunk

    • The trust record sets network_allowlist to only xquik.com, but there is no validation shown that the runtime blocks all other outbound destinations for this skill.
    • What can go wrong: if allowlist enforcement is incomplete, the skill could still exfiltrate data or reach arbitrary endpoints despite being marked restricted.
    • Fix: ensure policy enforcement uses this allowlist as a hard deny-by-default network gate and add a test that requests to non-allowlisted hosts are blocked.

@kriptoburak kriptoburak force-pushed the codex/add-hermes-tweet-agentguard-trust branch 2 times, most recently from 4729e99 to 2963a15 Compare June 29, 2026 18:50
@kriptoburak kriptoburak force-pushed the codex/add-hermes-tweet-agentguard-trust branch from 2963a15 to 6e571a9 Compare June 29, 2026 18:52
@kriptoburak

Copy link
Copy Markdown
Contributor Author

Follow-up on the automated review:

  • Pinned evidence refs to immutable commit b92e90e787c851dfb1820e065289130483117ffe.
  • Removed secret grants from the record.
  • Added a 90-day expiry for revalidation.
  • Re-ran jq, git diff --check, npm run build, and npm test locally. Target CI is green.

The remaining notes ask for registry-wide install/use-time verification and network enforcement tests. I did not add those broader policy changes in this data-record PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant