Add rasterXY serpentine raster path generator#126
Open
sina1988 wants to merge 1 commit into
Open
Conversation
Contributor
|
This looks good. Before I merge, what do you think about forcing step-over distance to be equal throughout? At the moment, the last raster is spaced up to 1.999999 times the normal raster spacing in order to fill the space. But it might be nive to distribute that gap across all rasters (and maybe print out the actual raster spacing for the user to see). Then you would have an extra line something like: and then in the for loop: or this could be added as a toggle for something like auto_stepover with default value False |
Author
|
Thanks, sounds good. I agree an auto_stepover=False toggle is better. Small point: since there are n_passes - 1 gaps, I think it should be: stepover_to_fill = (max_y - min_y) / (n_passes - 1) |
Contributor
|
Yep definitely. Good maths! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
rasterXY(...)helper tofullcontrol.geometry.waves.Why:
squarewaveXY(...)was not flexible enough for my use casemax_yNotes: