chore: Single-source version + one-command release script#2
Merged
Conversation
- Generate <decart/version.h> from version.h.in via configure_file so the version has one source of truth: project(VERSION) in CMakeLists.txt. Removes the hand-maintained header and any drift from the release tag. - Add scripts/release.sh X.Y.Z: bump the version, commit, tag, and push from main; the Release workflow publishes the GitHub release on the tag.
AdirAmsalem
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Tightens up the release process so cutting a version is a single, safe step.
<decart/version.h>is now generated fromversion.h.invia CMake'sconfigure_file, driven byproject(decart VERSION ...)inCMakeLists.txt. Previously the version was hand-duplicated in the header, which could silently drift from the release tag (CI only checked the CMake value). Now there's exactly one number to change and nothing can fall out of sync.scripts/release.sh X.Y.Z(run frommain) bumps the version, commits, tags, and pushes — then the existing Release workflow verifies the tag matches and publishes the GitHub release. No more editing files by hand.Releasing, going forward
Verified locally: configure generates the correct
version.h, the full build + unit tests pass, and the bump script only edits the project version line (shellcheck clean). No public API changes.