Prevent unauthorized access to private charts#1326
Open
girishpanchal30 wants to merge 1 commit into
Open
Conversation
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the frontend REST action endpoint (/wp-json/visualizer/v1/action/{chart_id}/{type}/) to prevent unauthorized access to private (non-published) charts. Previously, save/cancel actions bypassed all checks and other actions returned data for any numeric ID. The callback now validates the post is a Visualizer chart, requires edit_post for save/cancel and for non-published charts, and only exposes published charts to viewers via the existing visualizer_pro_show_chart filter.
Changes:
- Validate that the requested ID resolves to a real
visualizerCPT post before granting access. - Require
edit_postcapability forsave/canceland for any non-published chart. - Restrict published charts to the
visualizer_pro_show_chartfilter result.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verify the chart status and the user's permissions to access the chart information.
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/visualizer-pro/issues/589