Skip to content

London | 26-March-SDC | Ammad Ur Rehman | Sprint 4 | Implement cowsay in Python#539

Open
anosidium wants to merge 7 commits into
CodeYourFuture:mainfrom
anosidium:implement-cowsay
Open

London | 26-March-SDC | Ammad Ur Rehman | Sprint 4 | Implement cowsay in Python#539
anosidium wants to merge 7 commits into
CodeYourFuture:mainfrom
anosidium:implement-cowsay

Conversation

@anosidium

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Fulfilled the requirements.

Questions

Python syntax and idioms are weird.

@anosidium anosidium added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 14, 2026

@SlideGauge SlideGauge left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several notes from my side, could you fix them please?

Comment thread implement-cowsay/cow.py Outdated
Comment thread implement-cowsay/cow.py Outdated
Comment thread implement-cowsay/cow.py Outdated
Comment thread implement-cowsay/cow.py Outdated
Comment thread implement-cowsay/cow.py
Comment thread implement-cowsay/cow.py Outdated
@SlideGauge SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 20, 2026
@anosidium anosidium added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 24, 2026
@anosidium

Copy link
Copy Markdown
Author

Thanks for the review! I've addressed the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants