Fix RNFB modulemap, update Pods, downgrade Gradle#603
Merged
Merged
Conversation
Add iOS Podfile workarounds to fix @import RNFBApp resolution when building RNFB modules as static libs: inject OTHER_CFLAGS to point to RNFBApp.modulemap, set MODULEMAP_FILE for RNFBApp, and rewrite the generated RNFBApp.modulemap from a framework module to a plain module. Update Podfile.lock with numerous dependency bumps (Expo modules, Firebase 12.8.0 -> 12.10.0, RNFB 23.8.4 -> 23.8.8, react-native-quick-base64 2.2.2 -> 3.0.0, RNSVG and various expo packages) and adjust some local pod paths to expo/node_modules. Change Android gradle wrapper distribution from gradle-9.6.0 to gradle-8.14.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add iOS Podfile workarounds to fix @import RNFBApp resolution when building RNFB modules as static libs: inject OTHER_CFLAGS to point to RNFBApp.modulemap, set MODULEMAP_FILE for RNFBApp, and rewrite the generated RNFBApp.modulemap from a framework module to a plain module. Update Podfile.lock with numerous dependency bumps (Expo modules, Firebase 12.8.0 -> 12.10.0, RNFB 23.8.4 -> 23.8.8, react-native-quick-base64 2.2.2 -> 3.0.0, RNSVG and various expo packages) and adjust some local pod paths to expo/node_modules. Change Android gradle wrapper distribution from gradle-9.6.0 to gradle-8.14.3.