Antalya 26.5: Add OAuth2 login to clickhouse-client (--login / --login=device)#1973
Draft
zvonand wants to merge 2 commits into
Draft
Antalya 26.5: Add OAuth2 login to clickhouse-client (--login / --login=device)#1973zvonand wants to merge 2 commits into
zvonand wants to merge 2 commits into
Conversation
…next commit) --- Original cherry-pick message follows: Merge pull request #1606 from Altinity/feature/client-IdP Add OAuth2 login to clickhouse-client (--login / --login=device) # Conflicts: # docs/en/interfaces/cli.md # programs/client/Client.cpp # src/Access/TokenProcessorsOpaque.cpp
docs/en/interfaces/cli.md: kept the `clickhousectl skills` flags table
("ours"); discarded the `clickhouse-client` content from "theirs" because
commit 266165b on antalya-26.5 moved all clickhouse-client docs from
cli.md to client.md, so the clickhouse-client block no longer belongs here.
docs/en/interfaces/client.md: applied the source PR's documentation changes
here instead of cli.md — bucket-2 adaptation forced by the file move above.
Updated the `login` table row to `--login[=<mode>]`, added the
`--oauth-credentials` row, and added the "OAuth credentials file" section.
programs/client/Client.cpp: kept both `one-time-password` from "ours" (an
antalya-26.5 addition) and the source PR's new `login`/`oauth-credentials`
option definitions from "theirs".
zvonand
added
ai-needs-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add OAuth2 login flow to
clickhouse-client(#1606 by @BorisTyshkevich, #1799 by @zvonand).CI/CD Options
Exclude tests:
Regression jobs to run:
Combined port of 2 PR(s) (group
pr-1799). Cherry-picked from #1606, #1799.