Skip to content

Address lingering Windows line endings in code base #152

Description

@rhendrickson-sc

While adding Conifer 1.0 to projects, I've noticed that PhpStorm will point out that I'm committing files that end with CR LF line endings rather than the expected LF line endings. After a little digging, I discovered that ./docs/authorization.md is the culprit to this warning being shown.

Expected behavior

Files to have Unix line endings.

Actual behavior

Some files have Windows line endings.

Steps to reproduce behavior

Run the following command in the project root:

find -type f -exec grep -Iq . {} \; -and -exec grep -Il $'\r' {} +

You will then see that ./docs/authorization.md is using CR LF line endings rather than the expected LF line endings.

What version of WordPress/PHP/Timber/Conifer are you using?

Conifer 1.0

How did you install Conifer? (for example, via git clone, GitHub zip download, Composer/Packagist?)

lando composer require 'sitecrafting/conifer:^1.0'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions