Skip to content

Delete Workspace modal silently ignores 409 errors when active sessions remain #73

Description

@spersico

Honcho version / commit

0.16.0@sha256:f27b61df1af9e5c22758fc85a83a0e856e8aeba503db6dea7a9e35404f01dd48

What happened?

When deleting a workspace from the Delete Workspace modal, the Honcho API returns a useful 409 Conflict response if the workspace still has active sessions:

{
  "detail": "Cannot delete workspace '<NAME_OF_WORKSPACE>': active session(s) remain. Delete all sessions first."
}

OpenConcho does not show this error in the modal or elsewhere. The UI appears to do nothing / not react, which makes it look like the delete action failed silently.

Request:

  curl 'http://<HONCHO_URL>/api/v3/workspaces/<NAME_OF_WORKSPACE>' \
    -X 'DELETE' \
    -H 'content-type: application/json' \
    -H 'x-honcho-upstream: http://api:8000'

Observed Response: 409 Conflict with the JSON body above.

What did you expect?

OpenConcho should surface the API error message to the user instead of silently doing nothing.

Steps to reproduce

  1. Open OpenConcho.
  2. Navigate to a workspace that still has active sessions.
  3. Open the Delete Workspace modal.
  4. Confirm deletion.
  5. Observe that the API returns 409 Conflict.
  6. Observe that the UI does not display the error message and appears unchanged.

Additional context

  • OpenConcho: Docker image ghcr.io/offendingcommit/openconcho-web:0.16.0
  • Browser: Chrome 149 on Linux

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions